1883686 - Migrate shellService to use setPref instead of isEarlyStartup

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, task, P3)

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1883686 - Migrate shellService to use setPref for setDefaultBrowserUserChoice r?nalexander

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:barret, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/778d4c789ab7
Migrate shellService to use setPref for setDefaultBrowserUserChoice r=nalexander

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ deps/AccessibleText.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/1e27d0e912d8139972efda4ef48e3c922768dac9

Push with failures

Failure log -> ERROR - gmake[4]: *** [backend.mk:178: .deps/AccessibleText.h.stub] Error 94

Comment 5

[Beth Rennie [:beth] (she/her)]

I'm pretty sure this error is an intermittent unrelated to this change.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb686c6fb6c1
Migrate shellService to use setPref for setDefaultBrowserUserChoice r=nalexander

Comment 7

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_setDefaultBrowser.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/shell/test/browser_setDefaultBrowser.js | Set default with user choice disabled via nimbus - false == true - {"filename":"chrome://mochitests/content/browser/browser/components/shell/test/browser_setDefaultBrowser.js","name":"remote_disable","sourceId":641,"lineNumber":74,"columnNumber":10,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"han

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b27e969ebb0
Migrate shellService to use setPref for setDefaultBrowserUserChoice r=nalexander

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/3b27e969ebb0