1790436 - Crash in [@ IPC::EnumSerializer<T>::Write] in IPDLParamTraits<RemoteImageHolder>::Write()

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/33b005e7-a4de-4186-a974-ebc890220911

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(EnumValidator::IsLegalValue( static_cast<std::underlying_type_t<paramType>>(aValue)))

Top 10 frames of crashing thread:

0 XUL IPC::EnumSerializer<mozilla::gfx::ColorDepth, IPC::ContiguousEnumValidatorInclusive<mozilla::gfx::ColorDepth,  ipc/glue/EnumSerializer.h:60
1 XUL mozilla::ipc::IPDLParamTraits<mozilla::RemoteImageHolder>::Write dom/media/ipc/RemoteImageHolder.cpp:148
2 XUL mozilla::ipc::IPDLParamTraits<mozilla::RemoteVideoData>::Write dom/media/ipc/RemoteMediaData.h:303
3 XUL IPC::ParamTraits<nsTArray<mozilla::RemoteVideoData> >::WriteValues ipc/glue/IPCMessageUtilsSpecializations.h:355
4 XUL IPC::ParamTraits<mozilla::DecodedOutputIPDL>::Write ipc/ipdl/PRemoteDecoder.cpp:357
5 XUL IPC::ParamTraits<mozilla::DecodeResultIPDL>::Write ipc/ipdl/PRemoteDecoder.cpp:1053
6 XUL mozilla::FunctionRef<void  mfbt/FunctionRef.h:180
7 XUL mozilla::ipc::IPDLResolverInner::ResolveOrReject ipc/glue/ProtocolUtils.cpp:798
8 XUL std::__1::__function::__func<mozilla::PRemoteDecoderParent::OnMessageReceived /builds/worker/fetches/MacOSX11.3.sdk/usr/include/c++/v1/functional:1727
9 XUL mozilla::RemoteDecoderParent::DecodeNextSample dom/media/ipc/RemoteDecoderParent.cpp

It looks like this WriteIPDLParam call was added in bug 1787561.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1787561

Comment 2

[Brad Werth [:bradwerth] | Out until Feb 2025]

Attachment: Bug 1790436: Provide a default value for RemoteImageHolder::mColorDepth.

The default constructor for RemoteImageHolder assigns default values to
all of its members. gfx::ColorDepth does not define a default value. This
change makes it so RemoteImageHolder provides a default value.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08047518429b
Provide a default value for  RemoteImageHolder::mColorDepth. r=alwu

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/08047518429b