1790446 - Add build script to properly handle RNP's config.h.in file with #cmakedefine's instead of mangling during source updates

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Description

[Rob Lemley [:rjl]]

Mangling RNP's config.h.in via the update_rnp.sh script would be better handled by a build script that does the preprocessing at build time.

The generator script needs to handle the #cmakedefine lines and accept -D arguments to set additional DEFINE's beyond what is set at configure time in config.status.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1790446 - Stop rewriting RNP config.h.in when updating the source from upstream. r=dandarnell

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1790446 - Add build script to preprocess CMake config.h templates. r=dandarnell

Right now config.h.in is rewritten when the RNP source is updated.
This has caused problems when new lines are added to it.

Depends on D157151

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1790446 - Get RNP version during configure and set in config.h. r=dandarnell

Depends on D157152

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/688752ceab6d
Stop rewriting RNP config.h.in when updating the source from upstream. r=dandarnell
https://hg.mozilla.org/comm-central/rev/dffc4e833cdf
Add build script to preprocess CMake config.h templates. r=dandarnell
https://hg.mozilla.org/comm-central/rev/b53ebf6b4a3f
Get RNP version during configure and set in config.h. r=dandarnell

Comment 5

[Kai Engert (:KaiE:)]

Suggesting uplift to esr102, dependency for new RNP.

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9294320 [details]
Bug 1790446 - Get RNP version during configure and set in config.h. r=dandarnell

[Triage Comment]
Approved for esr102

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9294317 [details]
Bug 1790446 - Stop rewriting RNP config.h.in when updating the source from upstream. r=dandarnell

[Triage Comment]
Approved for esr102

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9294319 [details]
Bug 1790446 - Add build script to preprocess CMake config.h templates. r=dandarnell

[Triage Comment]
Approved for esr102

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 102.7.0:
https://hg.mozilla.org/releases/comm-esr102/rev/f904dc86d9f8
https://hg.mozilla.org/releases/comm-esr102/rev/9d5b0dfadeb4
https://hg.mozilla.org/releases/comm-esr102/rev/c63a8d2028ef