Closed Bug 1790487 Opened 17 days ago Closed 8 days ago

Change Colorways hover state text and aria label

Categories

(Firefox :: Messaging System, enhancement, P3)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox107 --- verified

People

(Reporter: asafko, Assigned: emcminn)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Let's please change the existing hover and aria-label text that includes just the colorway title to title and color description:

Default - > Current %Nightly/Beta/Firefox% colors
Playmaker -> Playmaker (red)
Expressionist -> Expressionist (yellow)
Visionary -> Visionary (green)
Activist -> Activist (blue)
Dreamer -> Dreamer (purple)
Innovator -> Innovator (orange)

Priority: -- → P3
Assignee: nobody → emcminn

Just to make sure, we want to avoid landing it last-minute in 106 Nightly to not create an extra load on the localization team.

(In reply to Ania from comment #2)

Just to make sure, we want to avoid landing it last-minute in 106 Nightly to not create an extra load on the localization team.

I'm working on this now, but I can put off landing it until next week so that it doesn't hit Nightly :)

Attachment #9294740 - Attachment description: WIP: Bug 1790487 - Change Colorways tooltip and aria-label → Bug 1790487 - Change Colorways tooltip and aria-label

Thank you so much, Emily!
My bad for not giving you an earlier heads-up about this.

Blocks: 1791426
Pushed by emcminn@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d5f095c02d2
Change Colorways tooltip and aria-label r=aminomancer,fluent-reviewers
Status: NEW → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Blocks: 1791861

I‘ve verified this issue using the latest Firefox Nightly 107.0a1 de build (Build ID: 20220928094353) on Windows 10 x64, macOS 12.5.1, and Linux Mint 20.2 x64.

  • When hovering the colorways icons, the following tooltip texts are displayed: Playmaker (red), Expressionist (yellow), Visionary (green), Activist (blue), Dreamer (purple), Innovator (orange).
  • For the default theme icon, the tooltip text has been implemented in a different enhancement (Bug 1791861).

Considering these, I’m marking this issue as Verified.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.