1790700 - Consider only showing number input up/down spinner buttons on hover or focus (and not at all on Android)

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Thomas Wisniewski [:twisniewski]]

The HTML number-type input's spinner buttons can get in the way, especially on Android, as noted at https://webcompat.com/issues/107783

Chrome on Android does not seem to show the spinners at all, which seems reasonable given how difficult it can be to even use such a small UI on a small touchscreen. On desktop it only reveals them when the input has focus, or on-hover. This all seems like a reasonable compromise to me, and should help mitigate such webcompat issues.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:emilio, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Should be a trivial patch if we wanted to. Does this need UX input?

Comment 3

[Gregory Pappas [:gregp]]

Attachment: Bug 1790700 - Show <input type='number'> spin buttons only on hover/focus, also hide them on Android r?emilio!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fedd91b7af1e
Show <input type='number'> spin buttons only on hover/focus, also hide them on Android r=emilio

Comment 5

[Cristian Tuns]

Backed out for causing reftest failures in number-spinbox-disabled.html

• Backout link
• Push with failures
• Failure Log
• Failure lines: REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/forms/input/number/not-other-type-unthemed-1.html != layout/reftests/forms/input/number/not-other-type-unthemed-1a-notref.html | image comparison, max difference: 0, number of differing pixels: 0
  REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/forms/input/number/number-spinbox-disabled.html != layout/reftests/forms/input/number/number-spinbox-disabled-notref.html | image comparison, max difference: 0, number of differing pixels: 0

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d4c98c06aec
Show <input type='number'> spin buttons only on hover/focus, also hide them on Android r=emilio

Comment 7

[Iulian Moraru]

Backed out changeset 8d4c98c06aec (bug 1790700) to resolve a merge back central to autoland conflict - this will be relanded after.

• Backout link

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11c91ab7be22
Show <input type='number'> spin buttons only on hover/focus, also hide them on Android r=emilio r=reland CLOSED TREE

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/269db9320df2
Backed out changeset fedd91b7af1e for causing reftest failures in /not-other-type-unthemed-1.html CLOSED TREE

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/11c91ab7be22