1790718 - [wpt-sync] Sync PR 35886 - [LayoutNG] OOF cached layout results when column balancing

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35886 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35886
Details from upstream follow.

Alison Maher <[e-mail]> wrote:

[LayoutNG] OOF cached layout results when column balancing

As a result of CL:3761109, OOFs may now participate in column
balancing. However, we can run into an infinite loop if OOF layout
results in extra minimal space shortage. If OOF layout uses the
previously cached layout result of the OOF, we would infinitely
detect the same space shortage.

Instead, clear out the OOF's layout result when column balancing to
ensure those results don't get re-used later on.

Bug: 1362550
Change-Id: Ic8266211d8c6b1574710f03b0eb1e85bb02621fc
Reviewed-on: https://chromium-review.googlesource.com/3894720
WPT-Export-Revision: efda0aedf1a88f5a0d8cf184e54fa705b813e2d0

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=288ac3e653f4f32fb012c43010ed3db631e97e73

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=eee7b4f7b5b970e1b268c4f2aa59ff9e156970b9

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

TIMEOUT: 1

Safari

PASS : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de8d0ca88946
[wpt PR 35886] - [LayoutNG] OOF cached layout results when column balancing, a=testonly

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/de8d0ca88946