1790722 - [wpt-sync] Sync PR 35887 - Make blink::TransformationMatrix API similar to gfx::Transform, step 1

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 35887 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35887
Details from upstream follow.

Xianzhu Wang <[e-mail]> wrote:

Make blink::TransformationMatrix API similar to gfx::Transform, step 1

This is to prepare for the merge of TransformationMatrix and
gfx::Transform.

• Reduce usages of TransformationMatrix::Mij() methods (i,j = 1..4).

• Add rc() and set_rc() to replace the original Mij() methods. The
  new methods have the same meaning as those of SkM44 and
  gfx::Matrix44 and have been used everywhere in chrome code.

• Add TransformationMatrix::ColMajor() to replace the original
  16-parameter constructor. gfx::Transform will have the same method.
  This is needed because the 16-parameter constructors in
  TransformationMatrix and gfx::Transform use different orders.

• Other smaller changes about construction.

Bug: 1359528
Change-Id: Iba15178dcc4605e972f8cfdb1bb69711bd812cc4
Reviewed-on: https://chromium-review.googlesource.com/3892438
WPT-Export-Revision: 868f4506bbd5947c71ebee4946a9b2502143ac5d

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=de18ea5e1ada58fa731ec4a7b6a28c9317a78abf

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
PASS: 2

Chrome

OK : 1
PASS: 2

Safari

OK : 1
PASS: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ce4ac66adef
[wpt PR 35887] - Make blink::TransformationMatrix API similar to gfx::Transform, step 1, a=testonly

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/1ce4ac66adef