1790843 - [Browser UI] Right located buttons in Toolbar/Tabstrip are shifted to the browser border when the window has a smaller size

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P2)

Description

[Mehmet]

Attachment: Actual_Menu_Button.png

Nightly 106.0a1 (2022-09-14) (64-Bit)
macOS 12.6

1.) Open a new Window
2.) Make it small as possible
3.) Take a look at the right located Menu button on the Toolbar and the Tablist button on the Tabstrip.

Actual: Right located buttons are shifted to the window border.

Expected: Buttons should keep the expected padding.

Screenshots are attached.

Thanks for checking.

Comment 1

[Mehmet]

Attachment: Actual_Tablist_Button.png

Comment 2

[Mehmet]

Attachment: Expectec_Menu_Button.png

Comment 3

[Mehmet]

Attachment: Expected_Tablist_Button.png

Comment 4

[Mehmet]

Attachment: Expected_Tablist_Button.png

Comment 5

[Dão Gottwald [:dao]]

Likely a regression from bug 1784223 that only seems to affect macOS. William, could you please look into this?

Comment 6

[William Durand [:willdurand]]

(In reply to Dão Gottwald [::dao] from comment #5)

Likely a regression from bug 1784223 that only seems to affect macOS. William, could you please look into this?

Indeed, this could be a regression from bug 1784223 (sorry!) but why would that affect the tablist as well? I'll take a look anyway.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784223

Comment 8

[William Durand [:willdurand]]

Attachment: Firefox 105

I can reproduce on MacOS with Firefox 104 and 105 so that does not seem "new".

I can fix the toolbar because I touched that part last but I don't know where the tablist issue is coming from at the moment..

Comment 9

[William Durand [:willdurand]]

I can reproduce on ESR 91 as well so not a new problem at all. The toolbar issue looks pretty bad so I am going to submit a patch shortly. For the tablist, I am less sure because there is a bit of padding at least.

Comment 10

[William Durand [:willdurand]]

Attachment: Bug 1790843 - Reduce the min width of the urlbar on small screens. r?dao!,Gijs

This patch adds some space after the menu button in the toolbar, which
makes things a lot better on MacOS and I noticed a small improvement on
Windows too.

Comment 11

[Mehmet]

Thanks for looking into the Toolbar button issue. Maybe the Tablist button issue can/will be fixed, if someone take a look into bug 1786968? :)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bce6dc799630
Reduce the min width of the urlbar on small screens. r=dao

Comment 13

[Marian-Vasile Laza]

Backed out changeset bce6dc799630 (Bug 1790843) for causing bc failures on browser_909779_overflow_toolbars_new_window.js.
Backout link
Push with failures <--> bc2
Failure Log

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:willdurand, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 16

[Dão Gottwald [:dao]]

Hey William, any update on this? Have you made any progress figuring out the test failure? Should this bug still be considered a P2?

Comment 17

[William Durand [:willdurand]]

I am sorry, this went nowhere. I don't really get with these tests fail :( I will try to get back to that in the coming days...

Comment 18

[William Durand [:willdurand]]

Hi Mehmet, can you actually reproduce this bug? (mainly with the navbar) - Both Gijs and I cannot reproduce anymore so maybe something else has fixed this bug magically :)

Comment 19

[Mehmet]

Attachment: new_current_issue.png

(In reply to William Durand [:willdurand] from comment #18)

Hi Mehmet, can you actually reproduce this bug? (mainly with the navbar) - Both Gijs and I cannot reproduce anymore so maybe something else has fixed this bug magically :)

Hi William, the initial issue with the right border clipping was fixed (probably with Bug 1795199) in the meanwhile. But the fix from 1795199 caused a side effect (see screenshot), that I had reported in bug 1796237, which was again merged to this bug here, with the reason, that your fix that your are working on in this bug here would fix the side effect reported in bug 1796237. :)

Comment 20

[William Durand [:willdurand]]

Ha, I see. Phew, thanks for keeping me updated, I lost track of everything here it seems. I will try to fix that new-ish UI glitch then.

Comment 21

[Mehmet]

(In reply to William Durand [:willdurand] from comment #20)

Ha, I see. Phew, thanks for keeping me updated, I lost track of everything here it seems. I will try to fix that new-ish UI glitch then.

Many thanks :)

Comment 22

[William Durand [:willdurand]]

As per comment 19, this bug has been fixed, likely by Bug 1795199.

Bug 1796237 has been marked as a dup of this bug but I don't think this is accurate since the information above is no longer valid. I am marking this bug as resolved and will reopen Bug 1796237.