1796237 - Regression: Overflow button is too close to the Addressbar

Status: REOPENED

(Firefox :: Theme, defect, P3)

Description

[Mehmet]

Attachment: actual regression.png

Nightly 108.0a1 (2022-10-19) (64-Bit)
macOS 12.6

1.) Open a window
2.) Make it small, so that the Overflow button appears
3.) Focus the Address Bar, so that the Drop Down List appears
4.) Hover over the Overflow button

Actual: Overflow button is too close to the address bar. 2px space is missing.

Expected: Between Overflow button and result list there should be 2px space. Please compare with the Reload button.

This is a recent regression.

A screenshot is attached.

Thanks for checking.

Comment 1

[Mehmet]

Attachment: Expected.png

• Expected Screenshot.

Comment 2

[Mehmet]

Attachment: compare Reload button.png

• Compare Reload button correct spacing.

Comment 3

[Mehmet]

This is the regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2022-10-17&enddate=2022-10-19

Emilio: Can you please take a look, if this could be caused by one of your changes in this range? Maybe with https://bugzilla.mozilla.org/show_bug.cgi?id=1795199 ?

Thanks :)

Comment 4

[Emilio Cobos Álvarez (:emilio)]

This shares the same root cause as bug 1790843, duping there because the main issue is that the urlbar just doesn't fit, and now we pull stuff in one direction vs the other.

Let me know if that's not accurate for some reason.

Comment 5

[Mehmet]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

This shares the same root cause as bug 1790843, duping there because the main issue is that the urlbar just doesn't fit, and now we pull stuff in one direction vs the other.

Let me know if that's not accurate for some reason.

*** This bug has been marked as a duplicate of bug 1790843 ***

Thanks for your feedback. Yes, finger crossed, that this issue will be fixed when the patch for bug 1790843 finally lands :)

Comment 6

[William Durand [:willdurand]]

I am reopening this bug since Bug 1790843 was about something else (and therefore the patch attached to it was no longer useful), which got magically fixed.

Comment 7

[Amy Churchwell [:amy]]

Hi there, what priority/severity do you think this bug should have? Is this something that you are actively working on? Thanks!

Comment 8

[William Durand [:willdurand]]

I am not actively working on that unfortunately, sorry!

Comment 9

[Amy Churchwell [:amy]]

I can reproduce this on macOS