1790873 - Cannot use printf_stderr from within js/src/

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Steve Fink [:sfink] [:s:]]

I don't know if this is specific to js/src, fwiw.

When I #include "mozilla/glue/Debug.h" from within js/src/gc/Marking.cpp, the build fails because it can't find #include_next <io.h>. If I fix that, it fails because it doesn't know _fileno(), _dup(), or _fdopen() by their underscore prefixed names. If I fix that (or rather, hack around it on Linux), then it seems to work, though I'm very doubtful that my fixes are correct and will work cross-platform.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1790873 - Move printf_stderr() to mozglue so it can be used within js/src

Comment 2

[Ben Visness [:bvisness]]

Attachment: Bug 1790873: Add js::DumpFmt as a convenient equivalent to printf_stderr. r=tcampbell

Depends on D164395

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1790873 - Send a full line at a time to printf_stderr in GLContext.cpp

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1790873 - Send a full line at a time to printf_stderr in CompositorOGL.cpp

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1790873 - Send a full line at a time to printf_stderr in nsUniscribeBreaker.cpp

Comment 6

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1790873 - Use stderr directly in printf_stderr rather than opening a separate file

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c425d724b81
Add js::DumpFmt as a convenient equivalent to printf_stderr. r=tcampbell

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/9c425d724b81

Comment 9

[Steve Fink [:sfink] [:s:]]

Oops. I was waiting for Nika's feedback, but didn't realize this bug had been closed because of the js::DumpFmt patch landing.

Comment 10

[Steve Fink [:sfink] [:s:]]

Nika: sorry for the confusion, but I'd like some guidance before doing any more work on this bug. I hadn't realized this bug was closed. And having some solution here would be useful in tracking down a crash whose frequency has been climbing.

Comment 11

[Nika Layzell [:nika] (ni? for response)]

Commented on the bug - apologies I'm not very on top of comments without corresponding ni?s or review requests.

Comment 12

[BugBot [:suhaib / :marco]]

The leave-open keyword is there and there is no activity for 6 months.
:sfink, maybe it's time to close this bug?
For more information, please visit BugBot documentation.

Comment 13

[BugBot [:suhaib / :marco]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D166853	Bug 1790873 - Use stderr directly in printf_stderr rather than opening a separate file	sfink	nika: Back Jan 2, 2024

:sfink, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit BugBot documentation.

Comment 14

[Steve Fink [:sfink] [:s:]]

:sfink, could you please find another reviewer or abandon the patch if it is no longer relevant?

Nope. Leave me alone bugbot, she's the right reviewer. It can wait.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01ddb562d770
Send a full line at a time to printf_stderr in CompositorOGL.cpp r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/296f6da7b6ed
Send a full line at a time to printf_stderr in nsUniscribeBreaker.cpp r=bobowen
https://hg.mozilla.org/integration/autoland/rev/6934f2978802
Use stderr directly in printf_stderr rather than opening a separate file r=glandium,nika
https://hg.mozilla.org/integration/autoland/rev/442a0de27b61
Move printf_stderr() to mozglue so it can be used within js/src r=glandium,nika

Comment 16

[Serban Stanca [:SerbanS]]

Backed out for causing Linux spidermonkey builds bustages in Printer.h.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-spider/dist/include/js/Printer.h:343:8: error: virtual function 'put' has a different return type ('bool') than the function it overrides (which has return type 'void')

L.E. There are also these sm bustages on Windows.

• Failure Log

And also build bustages on other platforms.

• Failure Log

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10e398febafa
Send a full line at a time to printf_stderr in CompositorOGL.cpp r=jgilbert
https://hg.mozilla.org/integration/autoland/rev/cccf8c596465
Send a full line at a time to printf_stderr in nsUniscribeBreaker.cpp r=bobowen
https://hg.mozilla.org/integration/autoland/rev/cd72b5ac2727
Use stderr directly in printf_stderr rather than opening a separate file r=glandium,nika
https://hg.mozilla.org/integration/autoland/rev/07c9202e33b5
Move printf_stderr() to mozglue so it can be used within js/src r=glandium,nika

Comment 18

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/10e398febafa
https://hg.mozilla.org/mozilla-central/rev/cccf8c596465
https://hg.mozilla.org/mozilla-central/rev/cd72b5ac2727
https://hg.mozilla.org/mozilla-central/rev/07c9202e33b5

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df68bb60104c
Send a full line at a time to printf_stderr in GLContext.cpp r=jgilbert

Comment 20

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/df68bb60104c