1794063 - Allow dump()ing to printf_stderr sinks

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Steve Fink [:sfink] [:s:]]

To get log output on eg Android, we have to use printf_stderr. Within js/, sometimes we want to be able to dump() various things. It would be good to be able to dump() to the printf_stderr destinations.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1794063 - Create an SEprinter for printing via printf_stderr

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:sfink, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 3

[Steve Fink [:sfink] [:s:]]

This bug depends on another bug, which should not be marked closed. (Or I should move stuff to a different bug that is still open.)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c729aa80e73e
Create an SEprinter for printing via printf_stderr r=jonco

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing Linux spidermonkey builds bustages in Printer.h.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/workspace/obj-spider/dist/include/js/Printer.h:343:8: error: virtual function 'put' has a different return type ('bool') than the function it overrides (which has return type 'void')

L.E. There are also these sm bustages on Windows.

• Failure Log

And also build bustages on other platforms.

• Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/231fbd4b933a
Create an SEprinter for printing via printf_stderr r=jonco

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/231fbd4b933a