1790886 - Update container query WPTs to match recent CSSWG behavior

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Shin[:dshin]]

Relevant WPT test here

As per the spec: "Style rules applying to a query container’s shadow-including descendants can be conditioned by querying against it, using the @container conditional group rule. [...] For selectors with pseudo elements, query containers can be established by the shadow-including inclusive ancestors of the ultimate originating element."

We seem to be using flat tree traversal for our container lookup.

Comment 1

[David Shin[:dshin]]

Attachment: ::slotted rules vs others in one container query

Seems that the resulting query container can differ within one container query, depending on the inner rules?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Yeah, this one is one I'm not convinced about, tbh. Seems weird that the spec is using something else than the flat tree (since CSS operates on the flat tree usually). I need to go through the spec issues that made the editors make that decision.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dholbert, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Jonathan Kew [:jfkthame]]

Marking this S3 for now, pending any further investigation; ni? emilio as a reminder to follow up comment 2.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1790886 - Fix container query WPT tests to reflect recent WG resolution. r=dshin,#style

As per CSSWG resolution in:

https://github.com/w3c/csswg-drafts/issues/5984#issuecomment-2112977366

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc97304e5b3d
Fix container query WPT tests to reflect recent WG resolution. r=jwatt

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46594 for changes under testing/web-platform/tests

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bc97304e5b3d

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot