[wpt-sync] Sync PR 35910 - compute pressure: Save last reported state
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox107 fixed)
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 35910 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/35910
Details from upstream follow.
Arnaud Mandy <arnaud.mandy@intel.com> wrote:
compute pressure: Save last reported state
As discussed in [1], any registering observer should get an update
at its sample rate. In the current implementation, if the second
registered observer has exactly the same quantization scheme as the
first one, it will be registered but will not get an update of the
state because it will be filtered by the ´PressureServiceImpl´
instance.By introducing the ´last_reported_state_´ in the
´PressureObserverManager´ class, it is possible to update the latest
registered observer with the latest update, which is still valid.[1] https://github.com/WICG/compute-pressure/issues/121
Bug: 1363494
Change-Id: Ie934c78b852c42668fdf5edd981a96f1ef4a3e5cReviewed-on: https://chromium-review.googlesource.com/3892779
WPT-Export-Revision: 1b85a3383d4243601b5ce137985e95983a67c3f1
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=751af08eb875f14dad5f8af8b4ce4065f5463dbd
|
|
Assignee | |
Comment 2•2 years ago
|
||
CI Results
Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 2 subtests
Status Summary
Firefox
FAIL : 1
TIMEOUT: 1
ERROR : 1
Chrome
OK : 1
PASS : 2
Safari
FAIL : 1
TIMEOUT: 1
ERROR : 1
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /compute-pressure/compute_pressure_basic.tentative.https.window.html [wpt.fyi]:
ERROR(Chrome:OK, Safari:ERROR)- An active PressureObserver calls its callback at least once:
FAIL(Chrome:PASS, Safari:FAIL) - Same quantization should also update second observer:
TIMEOUT(Chrome:PASS, Safari:TIMEOUT)
- An active PressureObserver calls its callback at least once:
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/269c52dfece0 [wpt PR 35910] - compute pressure: Save last reported state, a=testonly https://hg.mozilla.org/integration/autoland/rev/22ea827aebd1 [wpt PR 35910] - Update wpt metadata, a=testonly
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/269c52dfece0
https://hg.mozilla.org/mozilla-central/rev/22ea827aebd1
Description
•