1791219 - The scrollbar for <select> appears on the right side with "direction: rtl"

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[blinky]

Steps to reproduce:

1. Open attachment 9056088 [details].
2. Open the <select> menu in the testcase.

Actual results:

The scrollbar for <select> appears on the right side with direction: rtl.

Screenshot https://1drv.ms/u/s!AgMN9yoqpWv5i1Qbn5GRpT5QY4DR

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3bd83420170acdb01dbad4342363190d6c060dad&tochange=469683bb7d819852ada3095922a1535d18ffd7cb

Regressed by: bug 1782623

Comment 2

[blinky]

This similar to bug 1168691 and bug 1542193.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1782623, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1791219 - Fix direction of <select>. r=mconley

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1782623

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ccec9556d6c
Fix direction of <select>. r=mconley

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/2ccec9556d6c

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9295110 [details]
Bug 1791219 - Fix direction of <select>. r=mconley

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0
• List of other uplifts needed: nome
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner + test.
• String changes made/needed: nome
• Is Android affected?: No

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9295110 [details]
Bug 1791219 - Fix direction of <select>. r=mconley

Approved for 106.0b3, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/2932d7728042

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 106.0a1 (20220916213956) on Windows 10x64. Opening the select menu in the attached test case from comment 0 will display the scrollbar on the right side.
The issue is verified fixed with Firefox 107.0a1 (20220921214338) and 106.0b3 (20220922092933) from comment 10 on Windows 10x64, macOS 11 and Ubuntu 20.04. The select menu from the attached test case has the scrollbar on the left.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for release approval too as a dot release ride-along? Go ahead if so :)

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9295110 [details]
Bug 1791219 - Fix direction of <select>. r=mconley

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial one-liner + test.
• String changes made/needed: none
• Is Android affected?: No

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9295110 [details]
Bug 1791219 - Fix direction of <select>. r=mconley

Approved for 105.0.2.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/0fcbdd57a1d5

Comment 17

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 105.0.2 (20220929212302) from comment 16 on Windows 10x64, macOS 11 and Ubuntu 20.04. The scrollbar inside the test case is displayed on the left side as expected.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Added to the 105.0.2 release notes:

Fixed the scrollbar appearing on the wrong side of <select> elements in right-to-left locales