1791441 - Update browser_overflowScroll.js to use BrowserTestUtils.overflowTabs function

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, task, P3)

Description

[Tim Giles [:tgiles]]

Currently, the browser_overflowScroll.js uses a custom implementation for getting the tabs to overflow. With the addition of the shared overflowTabs function in Bug 1778450, we should update this test to used the shared implementation. The shared overflowTabs now lives in BrowserTestUtils, instead of shared-head.js

Note: we'll need to keep the left, right, isLeft, isRight, etc. block of variables intact. We just need to swap out the overflowTabs logic for the function call.

Comment 1

[Tim Giles [:tgiles]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions.
3. Start working on this bug.
   • As noted in Comment #0, you'll need to update the test to use BrowserTestUtils.overflowTabs() instead of the test's current implementation.
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #fx-desktop-dev channel on Element/Matrix most hours of most days.
4. Build your change with mach build and test your change with mach test browser/base/content/test/tabs/browser_overflowScroll.js --headless. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!
   • Your code will soon be shipping to Firefox users worldwide!

Comment 2

[Renzo]

Hi Tim, can I solve this bug?

Comment 3

[Tim Giles [:tgiles]]

Hi Renzo, feel free to solve this issue! I'll assign it to you. If you have any questions, feel free to reach out over on element or needinfo me here. Feel free to look at Bug 1791439 as an example as well.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 5

[Sage Jasinski]

Hi Tim, Does this overflowTabs still need refactoring? if so I'd love to give it a go.

Comment 6

[Tim Giles [:tgiles]]

Hi Sage, yeah this refactoring work is still valid. Thanks for the help! Please refer to Comment #1 for help getting started, but feel free to needinfo me here or reach out to me over on Matrix if you run into other issues along the way!

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 8

[Shreya Shah [:shasha]]

Hi Tim. Is this bug still valid? If yes, I would like to give it a try.

Comment 9

[Tim Giles [:tgiles]]

Hey Shreya, this bug is still valid, feel free to take a try at it. Thanks for the help! Feel free to needinfo me for help with this bug or reach out over on Matrix if you run into issues!

Comment 10

[Shreya Shah [:shasha]]

Attachment: Bug 1791441 - Updates the BrowserTestUtils.overflowTabs function and its usages in tests.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b5d3c7fd3d0
Updates the BrowserTestUtils.overflowTabs function and its usages in tests. r=tgiles

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/2b5d3c7fd3d0