1791442 - Wrong profile used when non-snap Firefox launched by a snap

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Sophie Winter]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:104.0) Gecko/20100101 Firefox/104.0

Steps to reproduce:

• Launch Firefox from a snap (in my case Yarn)

Actual results:

• Firefox came up in wrong profile

Expected results:

• Firefox should have come up with my normal default profile

(it seems this was already reported and fixed once, see bug 1674150)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Startup and Profile System' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mossop, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Dave Townsend [:mossop]]

Mike, this is the bug related to bug 1674150 comment 14. I don't know if another was ever filed though?

Comment 4

[Mike Kaply [:mkaply]]

It wasn't. I'll fix it in this bug.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1297520

Comment 6

[Mike Kaply [:mkaply]]

I'm discussing with Canonical to figure out the right thing here.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1297520

Comment 8

[Mike Kaply [:mkaply]]

Attachment: Bug 1791442 - Explicitly check for SNAP_NAME of firefox to detect Snap. r?emilio

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/959bcc2a6588
Explicitly check for SNAP_NAME of firefox to detect Snap. r=emilio

Comment 10

[Serban Stanca [:SerbanS]]

Backed out for causing xpcshell tests failures in test_snap_empty.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/profile/xpcshell/test_snap_empty.js | - Should have used the normal name. - "default-default" == "default"

Comment 11

[Mike Kaply [:mkaply]]

Working on a fix.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1791442 - Explicitly check for SNAP_NAME of MOZ_APP_NAME to detect Snap.

Make snap xpcshell tests run with the right environment variables
instead of tweaking them at runtime.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60cda7d831ca
Explicitly check for SNAP_NAME of MOZ_APP_NAME to detect Snap. r=mkaply,jmaher,xpcom-reviewers,nika

Comment 14

[Iulian Moraru]

Backed out for causing bc failures on browser_ua_snap_ubuntu.js.

Push with failures

Failure log

Backout link

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ada1aefdeb18
Explicitly check for SNAP_NAME of MOZ_APP_NAME to detect Snap. r=mkaply,jmaher,xpcom-reviewers,nika

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ada1aefdeb18

Comment 17

[Pascal Chevrel:pascalc]

Emilio, this is marked as an S2, should we uplift to beta or can it ride the 111 train? Thanks

Comment 18

[Mike Kaply [:mkaply]]

I think this can ride the trains.