Closed Bug 1791507 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35960 - [beacon-api] Fix sendondiscard web tests's assertions

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox107 fixed)

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35960 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35960
Details from upstream follow.

Ming-Ying Chung <mych@chromium.org> wrote:

[beacon-api] Fix sendondiscard web tests's assertions

  1. Move sendondiscard web tests to wpt_internal/:

    Tests in this file were not working properly as the BackgroundSync
    permission is set to Denied by default in the web test runner.
    Moving to wpt_internal/ allows the use of
    internals.setPermission() API.

  2. There was also a bug in expectBeacon() function which didn't
    check the total number of sent beacons properly.

This CL fixes the above issues.

Bug: 1293679,1364348
Change-Id: Ia037080f94303279154fa0d71d33cf364712590c
Reviewed-on: https://chromium-review.googlesource.com/3907264
WPT-Export-Revision: 2078510cf36d6b56358cf9e000c0f734f80cdfda

PR 35960 applied with additional changes from upstream: 55f82d7bde45475d65ca1ca9f71d62f740517801

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests

Status Summary

Firefox

ERROR: 7

Chrome

ERROR: 7

Safari

ERROR: 7

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3c939d46ada4 [wpt PR 35960] - [beacon-api] Fix sendondiscard web tests's assertions, a=testonly https://hg.mozilla.org/integration/autoland/rev/066b8de74130 [wpt PR 35960] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3c939d46ada4
https://hg.mozilla.org/mozilla-central/rev/066b8de74130

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.