1791629 - Uplift request workflow should only request relman review after uplift form is submitted

Status: RESOLVED FIXED

(Conduit :: General, task)

Description

[Connor Sheehan [:sheehan]]

At the moment both moz-phab and Lando set #release-managers! review on newly created uplift revisions. This means the revisions are immediately in RelMan's review queue before the uplift request form has been submitted.

We should:

1. Stop setting relman review in Lando and moz-phab.
2. Teach the phab-bot to set relman review on the entire stack when the uplift form is completed on one revision.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: GitHub Pull Request

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: uplift: stop setting `#release-managers!` review (Bug 1791629) r?grammar,zeid

Comment 3

[Zeid [:zeid]]

Looks like this is merged?

Comment 4

[Connor Sheehan [:sheehan]]

Still working on step 2.

Comment 5

[BMO Automation]

Attachment: GitHub Pull Request

Comment 6

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/97d578d0276844fd89e3e252c234bdc98a875a22

Comment 7

[David Lawrence [:dkl]]

This is live in production.