Open Bug 1791692 Opened 3 years ago Updated 3 years ago

Show the user contacts that have unparseable vCards

Categories

(Thunderbird :: Address Book, enhancement)

enhancement

Tracking

(Not tracked)

People

(Reporter: darktrojan, Unassigned)

References

Details

In places where we parse a vCard, we catch and log parsing errors in order to prevent the error breaking what we're doing. This doesn't help the user find and fix the problem, it only tells them that there is a problem. (Although if the card is already in our database, I don't know what the user can actually do short of deleting the contact and entering it again.)

We can improve the logging by printing what we do know about the contact. Potentially we could put some sort of warning in the UI, although if there's nothing useful the user can do there that may be more annoying.

We should have the UI say something if a corrupt vCard is imported. Corrupt cards could also enter the database from CardDAV. Any other ways?

In my experience the corrupt vcard will still show up in the contacts (even if search was broken). Thunderbird just won't show all entries for that contact. Seems like it Thunderbird just ignores lines that it can't parse. And maybe also following lines?! Didn't test that.
Also if you edit and save the corrupted contact within Thunderbird, Thunderbird saves only the data that is shown in the UI. Which means that the problematic data from the vcard will be erased.

So I think a nice solution would be:
Show a warning to the user that says: "This line [...] in contact XY can't be parsed by Thunderbird. Please edit the contact and re-enter the data to solve the problem."

Maybe easier to implement:
Just print the complete vcard and tell the user to compare it to the data that the Thunderbird adress book UI shows.

You need to log in before you can comment on or make changes to this bug.