1791918 - Ensure ORB blocks requests with UNKNOWN_CONTENT_TYPE when the response is recognized as a blocked type after sniffing in OnDataAvailable

Status: RESOLVED FIXED

(Core :: DOM: Networking, enhancement, P2)

Description

[Sean Feng [:sefeng]]

ORB doesn't block requests with UNKNOWN_CONTENT_TYPE, however it's possible that the response gets recognized as blocked type after sniffing in OnDataAvailable. We need to make sure this works as expected

Comment 1

[Andreas Farre [:farre]]

Attachment: Bug 1791918 - Part 1: Ensure that ORB handles UNKNOWN_CONTENT_TYPE correctly. r=sefeng!

Comment 2

[Andreas Farre [:farre]]

The only test I can see failing is cache-put.https.any.js, and I think that it's correct and that it should fail.

https://treeherder.mozilla.org/jobs?repo=try&revision=0e50c7e91ba89b05fc5f22107c158ece5a775db5

Comment 3

[Andreas Farre [:farre]]

Attachment: Bug 1791918 - Part 2: Make cache-put.https.any.js range test skip ORB check. r=sefeng!,asuth!

To allow the test to perform opaque response filtering, we need to
bypass the ORB safelist check. This is done, by forcing the MIME type
retrieval to fail and the validation of partial first response to
succeed.

Depends on D161142

Comment 4

[Andreas Farre [:farre]]

https://treeherder.mozilla.org/jobs?repo=try&revision=3036f96d50c215ab172a9c8dc24a80d186b3d9a3 thinks that wpt looks fine

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/235443c9a047
Part 1: Ensure that ORB handles UNKNOWN_CONTENT_TYPE correctly. r=necko-reviewers,sefeng,valentin
https://hg.mozilla.org/integration/autoland/rev/129b6d7f330e
Part 2: Make cache-put.https.any.js range test skip ORB check. r=sefeng,asuth

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37291 for changes under testing/web-platform/tests

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/235443c9a047
https://hg.mozilla.org/mozilla-central/rev/129b6d7f330e

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot