Enable the partially implemented ORB in Nightly
Categories
(Core :: DOM: Networking, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox108 | --- | fixed |
People
(Reporter: sefeng, Assigned: sefeng)
References
(Blocks 4 open bugs)
Details
(Keywords: perf-alert, Whiteboard: [necko-triaged][orb:m1], [wptsync upstream])
Attachments
(8 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Although current implementation misses bug 1532644, bug 1532646 and bug 1532648, it is still good to be enabled in Nightly just for testing what we have implemented so far are working as expected, and retained web compatibility.
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
This patch starts to actually blocking opaque responses
for most type of the resources that are defined in the spec.
There are still pieces missing such as blocking JSON responses,
and this is why it's called partially implemented.
This patch was originally written by farre, and I made some
modifications based on it.
Assignee | ||
Comment 3•2 years ago
|
||
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
I am not sure the purpose of this check. With ORB implemented, we
could block a request before its onStartRequest call, so the status
could be a failure.
Assignee | ||
Comment 5•2 years ago
|
||
Assignee | ||
Comment 6•2 years ago
|
||
This file is being fetched with a 404 error which is not expected.
Assignee | ||
Comment 7•2 years ago
|
||
Assignee | ||
Comment 8•2 years ago
|
||
If ORB doesn't block the request from service worker, then the
synthesized request should also not be blocked by ORB.
Pushed by sefeng@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bc263932875f Add an initial batch of ORB tests. r=smaug https://hg.mozilla.org/integration/autoland/rev/d46d8ce0e449 Allow partially implemented ORB to be used in Nightly r=emilio,smaug,necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/9bdfad8294c3 Update some tests due to ORB is taking affect r=dragana,smaug,necko-reviewers https://hg.mozilla.org/integration/autoland/rev/385cce3ce13e Update test_auth_dialog_permission.js to allow failures before onStartRequest r=necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/f6201b73f62f Ensure ORB clears out the headers r=valentin,necko-reviewers https://hg.mozilla.org/integration/autoland/rev/b7f0115f333b Make test_cache_padding.html to actually load the test_cache_add.js file r=necko-reviewers,valentin https://hg.mozilla.org/integration/autoland/rev/53922f348ffe Add more tests/config changes based on the ORB implementation r=smaug https://hg.mozilla.org/integration/autoland/rev/9596658a1a0f Allow Synthesized Request Bypass ORB checks r=smaug,valentin,necko-reviewers
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36695 for changes under testing/web-platform/tests
Comment 11•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bc263932875f
https://hg.mozilla.org/mozilla-central/rev/d46d8ce0e449
https://hg.mozilla.org/mozilla-central/rev/9bdfad8294c3
https://hg.mozilla.org/mozilla-central/rev/385cce3ce13e
https://hg.mozilla.org/mozilla-central/rev/f6201b73f62f
https://hg.mozilla.org/mozilla-central/rev/b7f0115f333b
https://hg.mozilla.org/mozilla-central/rev/53922f348ffe
https://hg.mozilla.org/mozilla-central/rev/9596658a1a0f
Upstream PR merged by moz-wptsync-bot
Comment 13•2 years ago
•
|
||
In the past 2 days these patches caused 11 regressions and broke several sites, one of them a top site in Europe (corriere.it), we should consider backing out these patches or at least set browser.opaqueResponseBlocking
to false
if that fixes the webcompat and usability regressions for our Nightly population.
Assignee | ||
Comment 14•2 years ago
|
||
Yeah, going to disable it in bug 1798227
Comment 15•2 years ago
•
|
||
(In reply to Pulsebot from comment #9)
Pushed by sefeng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc263932875f
Add an initial batch of ORB tests. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d46d8ce0e449
Allow partially implemented ORB to be used in Nightly
r=emilio,smaug,necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/9bdfad8294c3
Update some tests due to ORB is taking affect r=dragana,smaug,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/385cce3ce13e
Update test_auth_dialog_permission.js to allow failures before
onStartRequest r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/f6201b73f62f
Ensure ORB clears out the headers r=valentin,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/b7f0115f333b
Make test_cache_padding.html to actually load the test_cache_add.js file
r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/53922f348ffe
Add more tests/config changes based on the ORB implementation r=smaug
https://hg.mozilla.org/integration/autoland/rev/9596658a1a0f
Allow Synthesized Request Bypass ORB checks r=smaug,valentin,necko-reviewers
== Change summary for alert #35850 (as of Sat, 29 Oct 2022 15:30:14 GMT) ==
Regressions:
Ratio | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|
9% | wikia LastVisualChange | windows10-64-shippable-qr | cold fission webrender | 3,275.04 -> 3,555.25 |
7% | wikia SpeedIndex | windows10-64-shippable-qr | cold fission webrender | 1,088.43 -> 1,161.33 |
Improvements:
Ratio | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|
54% | wikia ContentfulSpeedIndex | windows10-64-shippable-qr | cold fission webrender | 1,841.00 -> 852.58 |
50% | wikia ContentfulSpeedIndex | linux1804-64-shippable-qr | cold fission webrender | 1,687.75 -> 847.58 |
50% | wikia ContentfulSpeedIndex | macosx1015-64-shippable-qr | cold fission webrender | 1,553.33 -> 783.00 |
46% | wikia ContentfulSpeedIndex | windows10-64-shippable-qr | fission warm webrender | 846.42 -> 456.58 |
44% | wikia ContentfulSpeedIndex | macosx1015-64-shippable-qr | fission warm webrender | 652.00 -> 367.75 |
... | ... | ... | ... | ... |
6% | wikia SpeedIndex | windows10-64-shippable-qr | fission warm webrender | 532.88 -> 503.17 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35850
Updated•2 years ago
|
Assignee | ||
Comment 16•2 years ago
|
||
So I did more try runs for wikia by using my patches in bug 1797983, I can confirm the regression are fixed with those patches.
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Description
•