1792029 - Change the probe "open_to_transaction_pending" to be a keyed histogram

Status: RESOLVED FIXED

(Core :: Networking, task, P2)

Description

[Andrew Creskey [:acreskey]]

In Bug 1789468 we added a probe that measures the time from asyncOpen in the child process up until the point that the transaction is added to the HttpConnectionMgr in the parent process.
Based on a discussion in the review comments, this should be a histogram keyed on the class of service since this timing can be greatly affected if the resource is tailed.

Comment 1

[Andrew Creskey [:acreskey]]

Attachment: Bug 1792029 - Change the probe "open_to_transaction_pending" to be a keyed histogram r=necko-reviewers

We're keying by classOfService since we don't want to merge prioritized and deprioritized channels.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19b5938cd941
Change the probe "open_to_transaction_pending" to be a keyed histogram r=necko-reviewers,kershaw

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/19b5938cd941

Comment 4

[Daniel Thorn [:relud]]

keyed for histogram should be immutable between revisions, per https://bugzilla.mozilla.org/show_bug.cgi?id=1794440#c4. To get a keyed histogram please change the histogram name.

Schema changes are blocked for all products until this is rectified.

Comment 5

[Andrew Creskey [:acreskey]]

(In reply to Daniel Thorn [:relud] from comment #4)

keyed for histogram should be immutable between revisions, per https://bugzilla.mozilla.org/show_bug.cgi?id=1794440#c4. To get a keyed histogram please change the histogram name.

Schema changes are blocked for all products until this is rectified.

Thanks for flagging this, patch incoming in Bug 1794840