179205 - flag options incorrect

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Flag options don't match what their type configuration says they should be.  In
particular, active plussed flags look inactive and unrequestable flags show a "?".

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: fix for problems

Comment 2

[Gervase Markham [:gerv]]

Comment on attachment 105677 [details] [diff] [review]
patch v1: fix for problems

r=gerv.

Gerv

Comment 3

[Dave Miller [:justdave]]

a=justdave

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: more comprehensive

This patch takes care of one extra situation resulting in a mismatch and cleans
up formatting by preventing (<input ...>) from wrapping between the input field
and the parentheses.

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 105679 [details] [diff] [review]
patch v2: more comprehensive

doesn't seem to want to let me okay the review. :-)  But that's what this is
supposed to fix, right? :)

r=justdave

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v3: one more fix

This patch handles the situation where something has been made inactive and a
flag isn't set for it.	In that case it should appear, but it was appearing.

Comment 7

[Dave Miller [:justdave]]

Comment on attachment 105681 [details] [diff] [review]
patch v3: one more fix

r= justdave

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Checking in template/en/default/flag/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/flag/list.html.tmpl,v 
<--  list.html.tmpl
new revision: 1.4; previous revision: 1.3
done