179206 - enter_bug isn't picking up version from URL

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Gervase Markham [:gerv]]

The URL above, for me, still fills in the version as "unspecified".

Gerv

Comment 1

[Jacob Steenhagen]

It selected 2.17 for me...

Comment 2

[Gervase Markham [:gerv]]

How strange. It's working now, including on my bookmarked query.

<shrug>

Gerv

Comment 3

[Bradley Baetz (:bbaetz)]

The cookie value gets precidence, which is why it started working the second
time, since hte cookie was then set.

REOPEN to decide if this is desired behaviour (I'd say no, personally)

Comment 4

[Gervase Markham [:gerv]]

I'm not sure it's a cookie thing; I don't have any sort of VERSION cookie on
this copy of Mozilla, and it's still working fine when I click the above URL.

Gerv

Comment 5

[Bradley Baetz (:bbaetz)]

Right, it goes:

1) look for cookie
2) look for url param

IOW, theres no way to override the cookie with a url param, which would be
useful with (for example) a link to enter bug from about:mozilla, or something.

ITs minor, but I still think its a bug.

Comment 6

[Gervase Markham [:gerv]]

I still don't get this. What exactly is going on?

Gerv

Comment 7

[Dave Miller [:justdave]]

The last version a user chose is stored in a cookie.  You can also pass a
version in on the query string in the URL to default the form to.  If you do the
latter, the cookie should be ignored.  It's not.  If you have a cookie, version
gets set to your cookie, regardless of anything passed in on the query string.

Comment 8

[GavinS]

Attachment: simple patch to swap the order of check for the version

This patch simply swaps around the order of the cookie version check and the
url version check.

Comment 9

[Bradley Baetz (:bbaetz)]

Comment on attachment 106692 [details] [diff] [review]
simple patch to swap the order of check for the version

Yep, thats it

r=bbaetz

Comment 10

[Dave Miller [:justdave]]

a=justdave

Brad, care to check it in?  I don't think Gavin has checkin privs.

Comment 11

[Bradley Baetz (:bbaetz)]

FIXED