1792163 - Private window does not use private icon on taskbar when opening a link from "private" Library into a new private window

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect, P1)

Description

[Fanolian]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0
Build ID: 20220922214429

Steps to reproduce

0. Set browser.privateWindowSeparation.enabled to true
1. Open Nightly in a regular window.
2. Open a private window. (This window should have a private browsing icon on taskbar.)
3. Open Library from the private window.
4. Right click a link in Library and choose Open in New Window.

Actual result

The link opens in a new private window, as indicated by the private logo on titlebar and no history is saved, yet the taskbar icon is the regular one. This new private window is also grouped with other regular windows.

Expected result

The new private window should have a private browsing icon on taskbar. It should be grouped with other private windows, if any.

Additional notes

1. This bug happens only when Library is opened from a private window. When it is opened from a regular window, there are Open in New Window and Open in New Private Window. Both work and group properly.

2. For Library opened from a private window, Open and Open in New Tab are also bugged if all private windows were closed.

Needinfo :bhearsum since he recently worked on bugs related to Private Window Separation.

Comment 1

[Fanolian]

Attachment: Bug 1792163 bugged taskbar icon screenshot.png

Screenshot of the bugged taskbar icon for private window.

Comment 2

[[e-mail] (:bhearsum)]

Thank for the detailed report! Mak, do you have any context or perspective to add? I'll try to work up a fix regardless, but I want to give you a chance to weigh in since we've talked about this recently. It seems like the Library already has some special behaviour for Private Browsing, which I didn't realize before.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: Bug 1792163: Private window does not use private icon on taskbar when opening a link from "private" Library into a new private window r?mak!

Comment 4

[Fanolian]

Sorry I forgot to set a tracking request flag for 106.
Is this bug important enough to request one despite 106 RC was out? Or just set one for 107?
Thanks.

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Fanolian from comment #4)

Sorry I forgot to set a tracking request flag for 106.
Is this bug important enough to request one despite 106 RC was out? Or just set one for 107?
Thanks.

Given that it doesn't actually impact privacy (no data is leaked outside of the private profile, even if it may look like it does) I don't think we need it for 106. I do think we should uplift for 107, though.

Comment 6

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on:

• Firefox 106.0;
• Firefox 105.0.3;
• Nightly 107.0a1;

Tested on:

• macOS 12;
• Windows 10;
• Ubuntu 22;

Could not reproduce on macOS and Ubuntu.
This bug is already set to NEW so i'm just going to update the tracking flags.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1132f52b18c3
Private window does not use private icon on taskbar when opening a link from "private" Library into a new private window r=mak

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1132f52b18c3

Comment 9

[Donal Meehan [:dmeehan]]

:bhearsum given the severity of this is S2 and Comment 5, what are your thoughts on submitting a beta uplift request?

Comment 10

[[e-mail] (:bhearsum)]

(In reply to Donal Meehan [:dmeehan] from comment #9)

:bhearsum given the severity of this is S2 and Comment 5, what are your thoughts on submitting a beta uplift request?

I'd be happy to have it uplifted, although I realized after posting that comment that it is not quite severe enough to really warrant it. Up to you :)

Comment 11

[Donal Meehan [:dmeehan]]

(In reply to [e-mail] (:bhearsum) from comment #10)

(In reply to Donal Meehan [:dmeehan] from comment #9)

:bhearsum given the severity of this is S2 and Comment 5, what are your thoughts on submitting a beta uplift request?

I'd be happy to have it uplifted, although I realized after posting that comment that it is not quite severe enough to really warrant it. Up to you :)

Thanks for the info. In that context, I'll set 107 to wontfix and this can ride the train with 108

Comment 12

[Giorgia Nichita, Release Desktop QA]

Reproduced the issue on an affected Nightly build from 2022-09-23, on Windows 10 x64.
Verified this issue as fixed on Firefox 108.0b5 (20221122190120) and 109.0a1 (20221122214324) on Win 10.