1797010 - Shift-enter in URL bar in private window does not set taskbar icon to private

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect, P3)

Description

[Fanolian]

+++ This bug was initially created as a clone of Bug #1792163 +++

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:107.0) Gecko/20100101 Firefox/107.0
Build ID: 20220922214429

Steps to reproduce

0. Set browser.privateWindowSeparation.enabled to true
1. Open Nightly in a regular window.
2. Open a private window. (This window should have a private browsing icon on taskbar.)
3. Type something in URL bar.
4. Shift-enter to open the url/search term into a new window.

Actual result

The new window is private, as indicated by the private indicator on titlebar and history is not saved, yet the taskbar icon is the regular one. This new private window is also grouped with other regular windows.

Expected result

The new private window should have a private browsing icon on taskbar. It should be grouped with other private windows, if any.

Additional notes

(Dedicated) Searchbar is not affected. Shift-enter does not open in a new window at all.

P.S. For future reference, should this bug (and bug 1792163, bug 1791757) be marked as blocking bug 1751010, or blocking bug 1749830 just like bug 1766636?

Needinfo :bhearsum since he recently worked on bugs related to Private Window Separation.

Comment 1

[Fanolian]

Forgot to change bug title...

Comment 2

[[e-mail] (:bhearsum)]

Definitely a real bug...probably an easy fix.

Comment 3

[[e-mail] (:bhearsum)]

Attachment: Bug 1797010: default private window feature to UrlbarInput.isPrivate r?adw!

I think that this has always the right thing to do, although until we enabled private window separation setting it in most cases would've had no effect -- although it's possible I'm unaware of some downside to setting this.

I'm not certain that this precisely the right place to set this (perhaps I should tweak them in _loadUrl instead?).

If there's a reasonable way to write a test for this I'd appreciate some guidance. Ultimately, the only state that changes because of this is on the nsIAppWindow chromeFlags, but I haven't seen an obvious way to get a handle on the window created here (unless I tweak this and various other code to start returning it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c168106a495
default private window feature to UrlbarInput.isPrivate r=adw

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7c168106a495

Comment 6

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 108.0b9 on Windows 10 64bit.