Closed Bug 1792195 Opened 2 years ago Closed 2 years ago

Quick Actions: Labeltext is too close to button border when window is shrinked

Categories

(Firefox :: Address Bar, defect)

defect

Tracking

()

VERIFIED FIXED
107 Branch
Tracking Status
firefox107 --- verified

People

(Reporter: mehmet.sahin, Assigned: daisuke)

References

Details

Attachments

(5 files, 1 obsolete file)

Attached image bug.png

Nightly 107.0a1 (2022-09-23) (64-Bit)
macOS

Looks like Quickactions lo longer wrap into the next line when the window is shrinked to a smaller size. But now the labeltext looks unpolished because it is cutoff and too close the border of the button.

It would be nice use ellipsis or a fade out affect instead.

Thanks.

Attached image fix with ellipsis.png
  • example fix with ellipsis.
Blocks: 1790814
Blocks: 1782974
No longer blocks: 1790814

Thank you very much for your reporting always, Mehmet!
I will fix it.

Assignee: nobody → daisuke
Status: NEW → ASSIGNED

(In reply to Daisuke Akatsuka (:daisuke) from comment #2)

Thank you very much for your reporting always, Mehmet!
I will fix it.

You are welcome :) Many thanks for fixing this. Just one note, but maybe you will consider this in your patch? Can you please keep the padding between the ellipsis and the button border? That would be great :) A screenshot is attached. Many thanks :)

Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4053f6c0e941
Apply ellipsis style to label. r=daleharvey
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
Attached image fixed.png (obsolete) —

Thanks :) Looks very good now in Nightly 107.0a1 (2022-09-28) (64-Bit) 👍

Attached image fixed.png
  • fixed screenshot.
Attachment #9296484 - Attachment is obsolete: true

The issue is verified fixed on Windows 10 and Ubuntu 22.04 using the latest Fx107.0a1.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: