1792422 - Dragging a PDF page while the Hand Tool and Draw tool are active will draw lines on the page

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect, P1)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: PDF_tools.gif

Found in

• 106.0b4 (20220925185751)

Affected versions

• 106.0b4 (20220925185751)
• 107.0a1 (20220925213821)

Tested platforms

• Affected platforms: Windows 10x64, macOS 11, Ubuntu 21.04, Windows 7x64
• Unnafected platforms: none

Steps to reproduce

1. Open a random PDF (http://www.pdf995.com/samples/pdf.pdf) and select the Draw tool from the PDF toolbar.
2. Open Tools menu and select Hand Tool.
3. Drag the page up and down.

Expected result

• No lines are drawn when dragging the page.

Actual result

• Dragging the page will also draw lines on the PDF page.

Regression range

• Will search for one ASAP if there is one.

Additional notes

• Attached a screen recording.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

This seems to be a regression.

3:59.31 INFO: Last good revision: c9960e3f58b790c0d52a52f3d31240360258b655
3:59.31 INFO: First bad revision: 0f68aa34cac6679474e01aeb98449963214baa58
3:59.31 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c9960e3f58b790c0d52a52f3d31240360258b655&tochange=0f68aa34cac6679474e01aeb98449963214baa58

Possible cause: Bug 1780839

Calixte, when you have time, can you please take a look! Thanks!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1780839

Comment 3

[Jonas Jenwald [:Snuffleupagus]]

Given that the HandTool doesn't really make sense during editing, it seems to me that the overall easiest solution probably is to temporarily disable it while editing is active (similar to how PresentationMode has always disabled it).

Comment 4

[Calixte Denizet (:calixte)]

Attachment: pr 15521: [Editing] Disable hand tool when editing (bug 1792422)

Comment 5

[Jonas Jenwald [:Snuffleupagus]]

Attachment: pr 15522: [Editing] Disable the HandTool during editing (bug 1792422)

Comment 6

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 107.0a1 (20221011160345) on Windows 10x64, macOS 12.3 and Ubuntu 20.04. The Hand Tool cannot be used if the draw tool is active.

Comment 7

[Marco Castelluccio [:marco]]

Ryan, PDF editing is enabled on 106. I'm marking this as wontfix though, given that the severity is low there's no need to worry.