1792470 - Multiple "Add Security Exception" dialogs when adding a calendar

Status: NEW

(Calendar :: Provider: CalDAV, defect, P3)

Description

[Tristan Miller]

I have a self-hosted instance of Radicale that serves a CalDAV calendar on port 5232 with a self-signed certificate. When I try to add this calendar to Lightning, I get seven duplicate "Add Security Exception" modal dialogs that need to be confirmed. After confirming the exceptions, the calendar still doesn't get added right away; I need to try a second time before it gets added.

Steps to reproduce:

1. From a fresh profile, press the "Calendar" button to set up a new calendar. A "Create New Calendar" dialog appears.
2. Select "On the Network" and press "Next".
3. Enter the username and location for the calendar (e.g., https://calendar.example.com:5232/foo/bar.ics/) and press "Find Calendars".
4. Seven separate "Add Security Exception" modal dialogs appear. In the seventh, press "Confirm Security Exception". Dismiss the remaining dialogs either by pressing "Confirm Security Exception" or "Cancel" -- it doesn't matter which button is pressed, though it may be necessary to dismiss the dialogs in the reverse order that they appeared. You will be returned to the original "Create New Calendar" dialog.
5. Press the "Find Calendars" button again. This time the usual authentication dialog pops up, and the calendar gets added normally.

Step 4 and 5 are problematic. Instead of seven "Add Security Exception" dialogs, there should be only one dialog, and pressing "Confirm Security Exception" should move on to the authentication dialog instead of taking the user back to the "Find Calendars" dialog.

This is a partial regression of the behaviour I described in Bug 1666871 (itself a duplicate of Bug 1750655). In those bugs, it was impossible to add a calendar with a self-signed security certificate on any port other than 443 because Thunderbird would always write port 443 for the host in the cert_override.txt file. This bug has most of the same symptoms, except that it does eventually let the user add the calendar on the second try.

Comment 1

[Magnus Melin [:mkmelin]]

Bug 1793531 is similar.