1792524 - Add support for serialization and deserialization of platform objects

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Alexandra Borovova [:Sasha]]

Add support for serialization of the generic platform object. The platform object, which implements WindowProxy, is added in the scope of bug 1770754 and the platform object, which implements Node, will be added in bug 1770731. It will require adding wdspec tests as well.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Lets block bug 1790361 once we know that we can fix it in M5.

It would be good to know how we could identify platform objects vs normal Javascript objects.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hi Olli, is there an easy way to identify objects as platform objects? As described above we would have to differentiate these from normal JavaScript objects eg. as created by the website. Thanks.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I assume you'll support only some platform objects. Would <interfacePrototype>.isInstance() work? See the dev-platform message titled
"[dev-platform] chrome-privilieged scripts: instanceof operator against DOM interfaces will soon be strictly rejected"

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

For reference the thread as mentioned in the last comment can be found here:
https://groups.google.com/a/mozilla.org/g/dev-platform/c/jc_kG5gmdpk/m/fDuAVsJ1BQAJ

We will have to support all the platform objects (except Node of type element and some others that we handle differently) as accessible by web content to match the WebDriver BiDi specification, and everything else as well when we want to use our implementation to also work in chrome scope.

As such is there a way to check if some random object is implemented as interface? I'm fairly sure that's all what we would need.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(not still sure how "serialization" would work)

I can't now immediately think anything which could be used to check whether something implements just any interface.

peterv or edgar might recall.

Comment 6

[Peter Van der Beken [:peterv]]

We currently don't have an API to check for "object implements interface".

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Peter Van der Beken [:peterv] from comment #6)

We currently don't have an API to check for "object implements interface".

Peter, how easy/hard would it be to get such an API added? Also where exactly would this need to happen?

Comment 8

[Peter Van der Beken [:peterv]]

You could expose IsDOMObject (https://searchfox.org/mozilla-central/rev/83b86005c6913c2062419efb8aabdf2e683aa47f/dom/bindings/BindingUtils.h#149) as a ChromeOnly API, I think that'll give you "object implements interface". (Assuming that are the semantics you want, note that it doesn't include interface objects, interface prototype objects, named property objects, …)

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Peter! That sounds good. We will have a look in how to get this implemented, and most likely will file a separate DOM bug for that.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Deserialization is simple enough so that we should combine the work with the serialization work.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1792524 - [dom] Make isDOMObject() available through ChromeUtils.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1792524 - [WebDriver BiDi] Add support for serialization and deserialization of generic platform objects.

Depends on D165420

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1792524 - [wdspec] Add tests for serialization and deserialization of generic platform objects.

Depends on D165421

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10fa415ea515
[dom] Make isDOMObject() available through ChromeUtils. r=smaug
https://hg.mozilla.org/integration/autoland/rev/865755e816b0
[WebDriver BiDi] Add support for serialization and deserialization of generic platform objects. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/98ec90915d25
[wdspec] Add tests for serialization and deserialization of generic platform objects. r=webdriver-reviewers,jdescottes

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37674 for changes under testing/web-platform/tests

Comment 16

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/10fa415ea515
https://hg.mozilla.org/mozilla-central/rev/865755e816b0
https://hg.mozilla.org/mozilla-central/rev/98ec90915d25

Comment 17

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 18

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham