1792542 - Thunderbird CARDDAV double quotation problem with phone numbers

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[js]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:105.0) Gecko/20100101 Firefox/105.0

Steps to reproduce:

• create a new contact on samsung s20: vcard will look like this: 'TEL;TYPE=VOICE,CELL:1212424'
• contact gets synced by activesync to server and by carddav to thunderbird
• edit contact (add a note for example) in thunderbird
• contact gets synced to server by carddav
• vcard will now look like this: 'TEL;TYPE="VOICE,CELL":1212424' - the content of TYPE will get quoted

Actual results:

the quotation will cause activsync clients (iOS, Samsung S20) not to show the phone number any more! The quotation seems to violate proper syncing/displaying the phone number.

Expected results:

Thunderbird should not quote!

Comment 1

[Geoff Lankow (:darktrojan)]

I'm sure there's a bug about this already but I can't find it. The link I added shows someone already looking at it in the ical.js library we use.

Comment 2

[Geoff Lankow (:darktrojan)]

I have made a fix for this upstream. Waiting to hear if the theory I'm working on is reasonable.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1792542 - Update ical.js from upstream. r=#thunderbird-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/42cf1e4d32c6
Update ical.js from upstream. r=mkmelin

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9303235 [details]
Bug 1792542 - Update ical.js from upstream. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): never worked
User impact if declined: Thunderbird creates an invalid vCard in some circumstances, leads to problems with other systems
Testing completed (on c-c, etc.): landed last week
Risk to taking this patch (and alternatives if risky): low, I think

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9303235 [details]
Bug 1792542 - Update ical.js from upstream. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 108.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/d177f98019d1

Comment 9

[Geoff Lankow (:darktrojan)]

Comment on attachment 9303235 [details]
Bug 1792542 - Update ical.js from upstream. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): never worked
User impact if declined: Thunderbird creates an invalid vCard in some circumstances, leads to problems with other systems
Testing completed (on c-c, etc.): in 108 beta 2
Risk to taking this patch (and alternatives if risky): low, I think

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9303235 [details]
Bug 1792542 - Update ical.js from upstream. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 102.6.0:
https://hg.mozilla.org/releases/comm-esr102/rev/35262b5973e9