1792612 - Stop opening AB dialog as window dialogs, open them only as subdialogs

Status: RESOLVED FIXED

(Thunderbird :: Address Book, task)

Description

[Alessandro Castellani [:aleca]]

We currently have 3 main address book creation dialogs:

• pref-directory-add.xhtml
• abAddressBookNameDialog.xhtml
• abCardDAVDialog.xhtml

These files are currently opened both as SubDialogs and window dialogs in various places.
We should cleanup all those random instances and ensure that the creation flows of AB related stuff is always redirected to the Address Book tab and we only use these as subdialogs.
We should leverage the externalAction() method.

This will ensure UI consistency between inContent and themeable dialogs.

Comment 1

[Alessandro Castellani [:aleca]]

Purely a code clean up and optimization, so even tho there are some very minor UI and color inconsistencies, there's no real need to uplift to 102.

Comment 2

[Alessandro Castellani [:aleca]]

Attachment: Bug 1792612 - Always open LDAP and Local address book dialogs as SubDialogs. r=#thunderbird-reviewers

When possible, we redirect to the AB tab and let that code handle the dialogs.
Otherwise we open a subdialog from where we are.

Comment 3

[Alessandro Castellani [:aleca]]

Try run: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=9fcf54774caad7d5a6306d3792480b5aac178784

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/27c399b8cf6c
Always open LDAP and Local address book dialogs as SubDialogs. r=thunderbird-reviewers,freaktechnik