1792664 - Participants list is not properly shrinking to its available height

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Martin Giger [:freaktechnik]]

The chat participants list is no longer shrinking to the available space in the window and instead takes up the entire height it needs, making it a couple thousand pixels high for some rooms. This leads to the entire chat conversation content layout flowing out the bottom of the window. I suspect this is related to the recent changes around the way flex works in XUL.

Comment 1

[Martin Giger [:freaktechnik]]

I tried to reproduce this in mozregression but couldn't get it to fail.

Comment 2

[Martin Giger [:freaktechnik]]

Managed to get a regression window: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=7bab1735598e56f6722fd21031b71cab20473bb4&tochange=85978099045fac33591340b7df0a1fb432bdbcea

Comment 3

[Magnus Melin [:mkmelin]]

You'll need to check the corresponding m-c revisions.

Comment 4

[Martin Giger [:freaktechnik]]

Yes, obviously. I would assume this is caused by bug 1689816 though I don't quite understand how. I also wonder if this is at its core the same issue as bug 1783417. Since it seems our layout allows the tabpanels to get longer if one of the tabs just pushes hard enough, leading to all tabs being that height now.

Comment 5

[Martin Giger [:freaktechnik]]

Attachment: Bug 1792664 - Fix chat tab contents overflowing window height. r=#thunderbird-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/80daa5a4a30c
Fix chat tab contents overflowing window height. r=thunderbird-reviewers,Paenglab