1792666 - Firefox fails to build because of getting confused about the SDK on macOS 10.15

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

After the requirement for using the 11.3 SDK was added I ran into errors when using it with:
ac_add_options --with-macos-sdk=$HOME/.mozbuild/macos-sdk/MacOSX11.3.sdk

Includes like <type_traits> would not be found. I traced this down to clang overriding the specified sdk because of the SDKROOT environment variable being set to /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk by the system python3.

This was fixed by:

--- a/build/moz.configure/toolchain.configure
+++ b/build/moz.configure/toolchain.configure
@@ -1176,7 +1176,7 @@ def compiler(
         wrapper = list(compiler_wrapper or ())
         flags = []
         if sysroot.path:
-            flags.extend(("--sysroot", sysroot.path))
+            flags.extend(("-isysroot", sysroot.path))
         if host_or_target.os == "OSX" and macos_target:
             flags.append("-mmacosx-version-min=%s" % macos_target)
         if provided_compiler:

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1792666 - Use -isysroot instead of --sysroot on mac.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/990b01753f77
Use -isysroot instead of --sysroot on mac. r=firefox-build-system-reviewers,nalexander

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1724374

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1792666 - Add comment that was meant to be added but ended up missing

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f957308dfcb
Add comment that was meant to be added but ended up missing DONTBUILD

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/990b01753f77
https://hg.mozilla.org/mozilla-central/rev/6f957308dfcb

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:glandium, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.