1792814 - Firefox view page is no longer displayed when clicked after accessing the homepage button while on the Firefox view page

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P1)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: fx_view_page_00.gif

Found in

• 106.0b5 (20220927185813)

Affected versions

• 106.0b5 (20220927185813)
• 107.0a1 (20220929014928)

Tested platforms

• Affected platforms: Windows 10x64, Ubuntu 20.04, macOS 11.6
• Unaffected platform: none

Preconditions

• Have the Home Page button added to the toolbar.

Steps to reproduce

1. Open the Firefox View page by clicking the Pinned icon.
2. Click on the Home button from the toolbar.
3. Click on the Firefox view button.

Expected result

• The Firefox View page is displayed.

Actual result

• Nothing happens.

Regression range

• Not a regression. I can reproduce the issue starting with bug 1762903 when the Firefox view tab was implemented.

Additional notes

• Attached a screen recording.
• Clicking the Back arrow, will display the Firefox View page. Also restarting the browser or moving the Firefox View button to another part of the browser (e.g toolbar) will make it function again.

Comment 1

[:Gijs (he/him)]

bug 1766896 should have dealt with this and off-hand I don't know why it didn't. Dão, do you know?

We don't show the home button on the toolbar by default anymore, unless you change to a custom homepage - but we know a significant number of people do that. It does look like this reproduces with a custom homepage too, unfortunately.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1792814 - Don't load the home page in hidden tabs such as Firefox View. r=gijs

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4d1d04d32cc
Don't load the home page in hidden tabs such as Firefox View. r=Gijs

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c4d1d04d32cc

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9296724 [details]
Bug 1792814 - Don't load the home page in hidden tabs such as Firefox View. r=gijs

Beta/Release Uplift Approval Request

• User impact if declined: see comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial patch
• String changes made/needed:
• Is Android affected?: No

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9296724 [details]
Bug 1792814 - Don't load the home page in hidden tabs such as Firefox View. r=gijs

Approved for 106.0b7, thanks.

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/31c0f74d1a5a

Comment 8

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 106.0b7 (20221002185807) and Firefox 107.0a1 (20221002212226) on Windows 10x64, macOS 13 and Ubuntu 20.04. Clicking the Home button while Firefox View is opened will open a new tab with the home content and the Firefox View can be accessed as expected after that. This was tested while using a Custom home page, a blank home page, and the default firefox home page.