1792862 - `About Firefox Nightly` dialog size changes(flickers) when rendering is complete.

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Alice0775 White]

Steps to reproduce:

1. Help > About Nightly

Actual results:
About Firefox Nightly dialog flickers.

Before landing Bug 1756450:
Dialog size changes are small.

After landing Bug 1756450:
It will appear smaller. After that, it becomes larger. BUG!
It is reproduced each time the dialog is displayed.

After landing Bug 1792337:
It will appear large. After that, it becomes smaller. BUG!
It is reproduced each time the dialog is displayed.

Expected results:
Flickering should be minimized as much as possible.

Comment 1

[Alice0775 White]

Screencast: https://youtu.be/s9ktsloJ5fU

Comment 2

[Robin Steuber (she/her) [:bytesized]]

I can't reproduce this.

@emilio - Can you reproduce it? Any thoughts on how this ought to be fixed?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792862 - Try to minimize flickering of about dialog. r=bytesized

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I couldn't repro either but I suspect comment 3 would help. Alice, mind testing it? https://treeherder.mozilla.org/jobs?repo=try&revision=336a85d334a4c537f4d423f8b917ae78e884a6d0

Thanks so much as always :)

Comment 5

[Robin Steuber (she/her) [:bytesized]]

I can't help but suspect that this problem is related to the problem mentioned in Bug 1792337 Comment 15:

width is fixed now, but the position is off center to the underlying window

The video makes it look like perhaps the window starts off being centered. Then it is resized, and is no longer in the center.

When I have a second, I'll try the attached patch and see if it fixes that issue too.

Comment 6

[Alice0775 White]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

I couldn't repro either but I suspect comment 3 would help. Alice, mind testing it? https://treeherder.mozilla.org/jobs?repo=try&revision=336a85d334a4c537f4d423f8b917ae78e884a6d0

Thanks so much as always :)

The try build fixed the problem.
The flicker problem is not reproduced in the try build.

Comment 7

[Robin Steuber (she/her) [:bytesized]]

I also gave it a try and it does seem to fix the centering issue as well.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Sweet, can you review it? Or should I ask someone else for review? Thanks!

Comment 9

[Robin Steuber (she/her) [:bytesized]]

I've got it, sorry for the delay!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddad5e8d563e
Try to minimize flickering of about dialog. r=bytesized

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ddad5e8d563e

Comment 12

[Rares Doghi, Desktop QA]

Hi Alice0775 White, I tried to reproduce this issue on my end as well in Nightly 107.0a1 (2022-09-29) but I didnt notice any Flickering for the About Firefox panel, Can you please check our latest Beta build 107.0b3 on your end and see if the issue still occurs ? you can find the build here : https://ftp.mozilla.org/pub/firefox/candidates/107.0b3-candidates/build1/win64/en-US/

Comment 13

[Alice0775 White]

This problem is no longer reproduced in Firefox 107.0b3.