1792337 - Nightly's About box is too wide

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

Nightly's About box is too wide. This bug is a regression from bug 1756450.

I bisected the regression to this pushlog:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d3302226f71f9b0851862900e729c57da71f7773&tochange=e630ef72be8d614ad1532a38a9981096eec7035a

I've only tested on macOS 12.6 on a MacBook Air.

Comment 1

[Chris Peterson [:cpeterson]]

Kirk, I think this bug is a regression from your fix for AppUpdater bug 1756450.

Comment 2

[Alice0775 White]

I can reproduce this on Windows10.

Comment 3

[Nikolajs]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 4

[Robin Steuber (she/her) [:bytesized]]

(In reply to Chris Peterson [:cpeterson] from comment #1)

Kirk, I think this bug is a regression from your fix for AppUpdater bug 1756450.

I think you are probably right. I'll try to get a fix up shortly.

Comment 5

[Robin Steuber (she/her) [:bytesized]]

Ah, I believe that this is Bug 1747675 rearing its head again. Let's see if I can actually fix it properly this time.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792337 - Make about dialog use modern flexbox emulation, and size to a smaller width. r=Gijs,bytesized

That was presumably the intention of the explicit width in the CSS but
that wasn't working.

While at it, use a proper deck rather than a hand-rolled one.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792337 - Add a more convenient API to size a window constrained to a default size. r=bytesized,Gijs

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb9421c2629c
Make about dialog use modern flexbox emulation, and size to a smaller width. r=Gijs,bytesized,application-update-reviewers

Comment 11

[Natalia Csoregi [:nataliaCs]]

Backed out as requested.

• backout: https://hg.mozilla.org/integration/autoland/rev/788c5ea7a6ecc454c012cfdd862df1505e2d93e6

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbab9be9312e
Make about dialog use modern flexbox emulation, and size to a smaller width. r=Gijs,bytesized,application-update-reviewers,preferences-reviewers

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cbab9be9312e

Comment 15

[Thorin [:thorin]]

width is fixed now, but the position is off center to the underlying window

Comment 16

[Robin Steuber (she/her) [:bytesized]]

Is it supposed to be centered?

Comment 17

[Thorin [:thorin]]

Attachment: center.png

Is it supposed to be centered?

it was before, now it looks weird and unprofessional. this is the horizontal centering, vertical centering is still perfect

Comment 18

[Robin Steuber (she/her) [:bytesized]]

This should be filed as a separate bug.

Comment 19

[Robin Steuber (she/her) [:bytesized]]

Actually, I wonder if it would make sense to fold this problem into Bug 1792862. I'll leave a comment there.

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afb7b7b3a8ce
Add a more convenient API to size a window constrained to a default size. r=bytesized,extension-reviewers,robwu,TYLin

Comment 22

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/afb7b7b3a8ce

Comment 23

[Daniel Holbert [:dholbert]]

The new size seems to be skinnier than the old size (the size we had before this bug here). I filed bug 1793179 on that, in case we want to pick a slightly larger size to avoid this being as obvious of a behavior change to users.

Comment 24

[Oana Botisan, Desktop QA]

Attachment: Screenshot 2022-10-24 at 16.27.17.png

The width is smaller on Firefox 107.0b4 using macOS 12.5.1. However is still larger than the one from Firefox 106.0.1.
Is this expected?

Comment 25

[Emilio Cobos Álvarez (:emilio)]

It's expected not to be exactly the same, yeah.

Comment 26

[Oana Botisan, Desktop QA]

Thank you for the clarification. I will mark this bug as verified fixed.