1792971 - Extension install panel disappears when switching between tabs

Status: VERIFIED FIXED

(WebExtensions :: General, defect)

Description

[Alex Cornestean]

Attachment: 2022-09-30_08h56_45.mp4

Affected platforms:

• Windows
• Linux
• MacOS

Affected versions:

• 107.0a1/20220929214556
• 106.0b6/20220929195234

Description:
The extension install panel will disappear when, once it’s displayed (from initiating an extension install), a new tab is opened and the user switches between the AMO tab and this new tab.

The issue occurs on the latest Nightly and Beta. The latest Firefox Release is unaffected.

Steps to reproduce:

1. Access https://addons.mozilla.org/en-US/firefox/addon/ublock-origin/ and click on the "Add to Firefox" button (but do not proceed further with the add-on installation. We are interested in the install panel)
2. Notice the install panel appears (to completely clarify, I'm referring to the panel with "Add" and "Cancel" buttons)
3. While the install panel is displayed, open a new tab via the "+" button beside the tab with AMO. Focus is switched to this new tab
4. Switch back to the AMO tab and notice the install panel has disappeared

Actual:
The install panel disappears when switching between tabs

Expected:
The install panel should persists when switching between tabs

The issue appears to have been caused by a fix to this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1565751. More precisely, mozregression identified the first part of the fix as the culprit: “Bug 1565751: Use 'SetURI' event for custom new window. r=adw,scunnane”.

Differential Revision: https://phabricator.services.mozilla.com/D155184

Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=81e4e05408f2534514372fcf8108a43b0b1542b7&tochange=4cef8491818d39b729267a6ccd09ba517311726e

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1565751

:daisuke, since you are the author of the regressor, bug 1565751, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[William Durand [:willdurand]]

The issue occurs on the latest Nightly and Beta. The latest Firefox Release is unaffected.

I also confirm this is working for me with FF 105 and broken with Nightly.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Thank you very much for your report.
Yes, I also could reproduce this issue, will take a look.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1792971: Suppress popup notification while async tab switching.

Comment 5

[Pascal Chevrel (relman team) -> :pascalc]

Daisuke, does it need to be uplifted in 106 as it is a 16 regression? We are in our last week of betas. Thanks!

Comment 6

[Daisuke Akatsuka (:daisuke)]

Hi Pascal!
Thank you very much, but sorry, the patch is still under review.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9dd268c4cf21
Suppress popup notification while async tab switching. r=adw,zombie

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9dd268c4cf21

Comment 9

[Alex Cornestean]

Verified the fix on the latest Nightly (107.0a1/20221011093208) under Windows 10 x64 and Ubuntu 16.04 LTS.

The install panel persists when switching between tabs, confirming the fix.

For more details, see the attached video.

Comment 10

[Alex Cornestean]

Attachment: 2022-10-11_15h33_34.mp4