Closed
Bug 1792976
Opened 2 years ago
Closed 2 years ago
./mach esmify does not update eslintignore, leads to unexpected changes
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
107 Branch
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: jdescottes, Assigned: arai)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In Bug 1790473, we have a file which is currently eslintignored: remote/cdp/Protocol.jsm (eslint ignore entry).
When migrating the file to ESM, it did not update the entry in eslintignore and also tried to lint --fix the file, which lead to unexpected formatting changes (and also took a long time while running the script :))
It would be great if the script could check if the path is mentioned in eslintignore and update it before attempting to run eslint --fix .
|
||
Updated•2 years ago
|
Severity: -- → S4
|
|
||
Comment 1•2 years ago
|
||
I'm not really sure what component this belongs in, but build metadata says esmify belongs to Core :: General, so...
Severity: S4 → N/A
Component: XPConnect → General
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/bd23f15494ad Update path in .eslintignore in mach esmify command. r=yulia
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox107:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•