1792993 - Log additional error message in console when AddonManager.installSitePermsAddonFromWebpage throws

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

With https://phabricator.services.mozilla.com/D156192 and https://phabricator.services.mozilla.com/D151477 , requestMIDIAccess could be rejected for different reasons:

• the user rejected the addon prompt
• requestMIDIAccess was called from a plain-IP page
• requestMIDIAccess was called from a remote origin iframe
• requestMIDIAccess was called from a public etld page

at the moment, all of those cases reject with the same message: "WebMIDI requires a site permission add-on to activate"

This is good when the user caused the rejection, not so much when the AddonManager caused it.

It would be nice to tweak the error message to expose the actual reason of the rejection so developers could act on that

We might also mention the media.navigator.permission.disabled pref so developers could workaround those restriction in development phases if they don't have a proper secure environment

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1792993 - Log additional error message in console when Addonmanager.installSitePermsAddonFromWebPage throws. r=pbz.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cb45fde952c
Log additional error message in console when Addonmanager.installSitePermsAddonFromWebPage throws. r=pbz.

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6cb45fde952c