1793088 - Unable to switch from Firefox View directly to other tabs using TAB key

Status: VERIFIED FIXED

(Firefox :: Keyboard Navigation, defect, P2)

Description

[Bogdan Maris, Desktop QA]

Attachment: Gif showing the issue

Found in

• Firefox 106.0b6

Affected versions

• Firefox 106.0b6
• Latest Nightly 107.0a1
• Firefox

Tested platforms

• Affected platforms: Windows 10, macOS 11.6 and Ubuntu 21.04

Steps to reproduce

1. Open 1 or 2 tabs
2. Click Firefox View button
3. Try to reach the new tab with TAB key from the keyboard

Expected result

• User can cycle through Firefox View and the opened Tabs

Actual result

• User can't cycle through the opened tabs using TAB key once focused on Firefox View

Regression range

• Not a regression since this is also the behavior on old Nightly builds from 2022-05-10, close to when this feature existed.

Additional notes

• If the users have a normal tab in focus they can cycle through the tabs and Firefox View using TAB key without issues.

Comment 1

[Kelly Cochrane [:kcochrane]]

Based on discussion with UX and a11y team, the plan is to treat Fx View as a button in terms of how you can interact with it via keyboard. Users will be able to tab to/from the button (as opposed to using arrow keys like when cycling through tabs) regardless of where it's located in the browser.

Comment 2

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1793088 - Make first available tab focusable when Fx View is open r=dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a1431ca8979
Make first available tab focusable when Fx View is open r=dao

Comment 4

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1793088 - Update browser.ownerDocument to win.document in automated test r=dao

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 0a1431ca8979 (Bug 1793088) for causing failures browser_firefoxview_tab.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=bbuaMhBaStu7uXyTGKlLjg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=0a1431ca8979992a67483226552cd8bd8b9729bb

Log: https://treeherder.mozilla.org/logviewer?job_id=393839445&repo=autoland&lineNumber=26157

Backout: https://hg.mozilla.org/integration/autoland/rev/56b6e7dfbdad9d8f514eac7a4a2184f3e0b8dbad

Comment 6

[Kelly Cochrane [:kcochrane]]

Updated patch to check that Fx View button has focus before tabbing over to the first available tab. Waiting for review.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/caddc49839d3
Make first available tab focusable when Fx View is open r=dao

Comment 8

[Marian-Vasile Laza]

Backed out changeset caddc49839d3 (Bug 1793088) for causing bc failures on browser_firefoxview_tab.js
Backout link
Push with failures <--> bc3
Failure Log

Comment 9

[Kelly Cochrane [:kcochrane]]

Submitted another update for Dao to review.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd5db2935a3b
Make first available tab focusable when Fx View is open r=dao

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bd5db2935a3b

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kcochrane, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox107 to wontfix.

For more information, please visit auto_nag documentation.

Comment 13

[:Gijs (he/him)]

Jamie wrote in bug 1785272 comment 43 that this isn't working for him, so going to ping here to doublecheck if this is definitely still not working on today's nightly, and if not, exactly in what way it isn't working...

Comment 14

[Kelly Cochrane [:kcochrane]]

(In reply to :Gijs (he/him) from comment #13)

Jamie wrote in bug 1785272 comment 43 that this isn't working for him, so going to ping here to doublecheck if this is definitely still not working on today's nightly, and if not, exactly in what way it isn't working...

This seems to work as expected for me with the latest Nightly build. I should note that on mac/OSX, this does only work as expected once you turn on that System Preferences > Keyboard > Shortcuts > "Use keyboard navigation to move focus forward and Shift Tab to move focus backward.".

With Firefox View open/active, I'm able to tab over from Firefox View to the first visible tab and then use the arrow keys to navigate through the opened tabs.

Comment 15

[James Teh [:Jamie]]

Sooo... I just tested this again and it seems to be working just fine on Windows. 😳 I tested this multiple times yesterday and it was failing every time, and I was pretty sure I was running latest Nightly. But maybe I wasn't. Or something. Anyway, I'll just go hide in a corner or something.

Comment 16

[Bogdan Maris, Desktop QA]

Verified that now I can cycle from the Firefox View button to the first tab using Firefox 108.0b2 across platforms (Windows 10, macOS 11.6 and Ubuntu 22.04).