179309 - basic search for <comma> fails

Status: RESOLVED DUPLICATE of bug 67036

(Bugzilla :: Query/Bug List, defect)

Description

[timeless]

Internal Error
 

Bugzilla has suffered an internal error. Please save this page and send it to
[e-mail] with details of what you were doing at the time this message
appeared.

URL:
http://bugzilla.mozilla.org/buglist.cgi?short_desc_type=allwordssubstr&short_desc=%2C&product=Bugzilla&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&emailassigned_to1=1&emailtype1=exact&email1=&emailassigned_to2=1&emailreporter2=1&emailqa_contact2=1&emailtype2=exact&email2=&bugidtype=include&bug_id=&votes=&changedin=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&remaction=run&namedcmd=beos-checkins&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0=
Cannot seem to handle short_desc and allwordssubstr together.

Variables:

Comment 1

[Gervase Markham [:gerv]]

Here's the problem:

Search.pm, sub GetByWordList(Substr)?:
    foreach my $w (split(/[\s,]+/, $strs)) {

We allow both space-separated and comma-separated lists of words or strings. If
the string is just a comma, then it bypasses our checks for no-value, but we
don't have any words, so you get nothing out of the sub which constructs the
SQL, and this error message.

We don't have this problem with just spaces, because the value gets trimmed.

Options:
- disallow comma-separated lists, and make them separable only by whitespace
  Pro: can search for only commas (but why)
  Con: some people may use commas as separators
- Check for a string containing only commas and treat it as empty
  Pro: Keep current split behaviour
  Con: can't search for commas; unexpected behaviour (condition ignored) when
       you try.

Gerv

Comment 2

[timeless]

i'd prefer dwim behavior. if i enter just whitespace or just a comma, search for it.

also, i'm guessing i can't do csv style searches: "the,", "something", we might
want to consider allowing them. i suppose most people don't want to search for
commas, but considering all of the wonderful bugs that our CSV support
introduced, i'm much more likely to want to search for commas and csv strings
today than i was a week ago.

Comment 3

[Bradley Baetz (:bbaetz)]

This isn't a regression; 2.16 does the same (except that the internal error is
printed to the error_log, not the screen, giving a 500 error) This also doesnt'
work in 2.14, which just stops teh script outpu after printing the 'please wait'
screen

Comment 4

[Antonis Christofides]

See also bug 67036.

Comment 5

[Bradley Baetz (:bbaetz)]

*** Bug 204854 has been marked as a duplicate of this bug. ***

Comment 6

[Kurt Werle]

Yeah, I want to search for all bugs where I've addressed a remark to somebody. 
In all of those I wrote something like:
Somebody,
Please get off your butt and ...

So, yes, I want to search for "Somebody,"

Comment 7

[Frédéric Buclin]

*** Bug 340892 has been marked as a duplicate of this bug. ***