1793315 - unified folder doesn't have correct unified-specific attributes

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Wayne Mery (:wsmwk)]

Attachment: Proper unified folder context menu

Unified folders are similar to virtual folders, with special properties - similar to https://support.mozilla.org/en-US/kb/using-saved-searches

In version 102 and 106, on multiple computers, these properties are incorrect. I see menu items associated with normal folders which unified folders do not have, for example compact and new folder.

STR

1. profile with at least two mail accounts (with inboxes)
2. do View > Folders > Unified
3. right+click the root unified Inbox

Expected results: proper menu items for Unified Inbox - see screen shot
Actual results: menu items for normal folders - see screen shot - compact and new folder should not be listed

Alice, can you find the regression range?

Comment 1

[Wayne Mery (:wsmwk)]

Attachment: Incorrect context menu

Comment 2

[Alice0775 White]

Works for me in Tb106.0b3 and Tb102.3.1 Windows10.

Comment 3

[Wayne Mery (:wsmwk)]

On my Mac, only the Inbox is affected. The other six unified folders are correct. Also in troubleshoot mode.

Comment 4

[Alessandro Castellani [:aleca]]

Is this still happening?

Comment 5

[Wayne Mery (:wsmwk)]

Attachment: Screenshot 2023-06-02 at 12.00.05 AM.png

Perhaps not as incorrect, but still incorrect.
With daily, for the Unified Inbox it offers "New Folder".
It also offers "Favorite" - but I'm not sure if that is a regression compared to version 102.

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1793315 - Have 'New Folder' dialog require a selected folder. r=mkmelin

When called on folders that don't allow the creation of subfolders, the dialog
appears with the folder seletion widget labeled 'Choose Folder…". However,
the dialog could still be accepted without the user doing so. In the case of
the unified inbox, this would lead to folder on the file system that was not
reflected in the GUI.

Additionally, the check for an already existing subfolder with the entered name
wasn't performed directly after selecting a different parent folder.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a24305279e52
Have 'New Folder' dialog require a selected folder. r=mkmelin