1793543 - Grey border in dark mode around fieldset elements inside a dialog

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alessandro Castellani [:aleca] - PTO until Nov 16]

Attachment: Screen Shot 2022-10-03 at 9.43.34 PM.png

The fieldset element is styled with a grey border from the themeableDialog.css when in dark mode: https://searchfox.org/comm-central/rev/1749f88c7a80c1a2b5bafc95111a82736175cb18/mail/themes/shared/mail/themeableDialog.css#529

Is this necessary for some specific section or dialog?
It looks a bit foreign.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1793543 - Never show a border on fieldset in in-content pages. r=aleca

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2125f017731f
Never show a border on fieldset in in-content pages. r=aleca

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9297120 [details]
Bug 1793543 - Never show a border on fieldset in in-content pages. r=aleca

[Approval Request Comment]
User impact if declined: border around fielsets on in-content pages with dark theme
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9297120 [details]
Bug 1793543 - Never show a border on fieldset in in-content pages. r=aleca

[Triage Comment]
Approved for beta

Comment 5

[Daniel Darnell [:dandarnell]]

Thunderbird 106.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/7935196f0d67

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9297120 [details]
Bug 1793543 - Never show a border on fieldset in in-content pages. r=aleca

[Triage Comment]
Approved for esr102

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 102.4.0:
https://hg.mozilla.org/releases/comm-esr102/rev/7670ffab3155