1793558 - [Permissions] “Allow” status drop-down button width is too long

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Dana Lucaci, Desktop QA]

Attachment: "Allow" button.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.5 Safari/605.1.15

Steps to reproduce:

1. Visit https://permission.site/.
2. Click on " Notifications" button.
3. Click on "Allow" button in the notification panel.
4. Go to about:preferences#privacy.
5. Click on the Notification “Settings…” button.
6. Observe the “Allow" drop-down button.

Actual results:

The “Allow” drop-down width is too wide.

Expected results:

The “Allow” drop-down width is properly displayed, matching the “status” table head width.

Comment 1

[Dana Lucaci, Desktop QA]

Regression range

• First bad: 415da4b53bdd9ff553b009404d5fc765db7d6144

• Last good: 972c119dfc86702a5891f1423d369fc6e4123d46

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=972c119dfc86702a5891f1423d369fc6e4123d46&tochange=415da4b53bdd9ff553b009404d5fc765db7d6144

• Potentially regressed by: Bug 1784265 - Figure out what to do with flex="" attributes when emulating -moz-box with flexbox.

Comment 2

[Bogdan Maris, Desktop Test Engineering]

Thanks for this issue, I was able to reproduce it on Windows 10 on my end, making this issue as new and setting the affected flags.

Comment 3

[Itiel]

I managed to fix it by:

1. Adding display: flex to this element: https://searchfox.org/mozilla-central/rev/560b7b1b174ed36912b969eee0c1920f3c59bc56/browser/components/preferences/dialogs/sitePermissions.js#354
2. Adding flex: 3 here: https://searchfox.org/mozilla-central/rev/560b7b1b174ed36912b969eee0c1920f3c59bc56/browser/components/preferences/dialogs/sitePermissions.css#5
3. Adding flex: 1 here: https://searchfox.org/mozilla-central/rev/560b7b1b174ed36912b969eee0c1920f3c59bc56/browser/components/preferences/dialogs/sitePermissions.css#21

... However that doesn't seem to be the right fix.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1793558 - Fix a typo introduced in bug 1784265. r=Itiel

This fixes a typo in here:

https://hg.mozilla.org/integration/autoland/rev/fcb1a053fbe232205c71a5e72b137675fff5d343#l13.21

Which changed a "3" by a "1", unintendedly. Unify the styling, to have
one source of truth rather than 3.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/795e45d6deb3
Fix a typo introduced in bug 1784265. r=Itiel,preferences-reviewers,Gijs

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/795e45d6deb3

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9297095 [details]
Bug 1793558 - Fix a typo introduced in bug 1784265. r=Itiel

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Typo fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 107.0a1 (2022-10-04) on Windows 10x64. The dropdown box for Allow or Block permission has a bigger width than the Status area from above.
The issue is verified fixed with Firefox 107.0a1 (20221011160345) on Windows 10x64, macOS 12, and Ubuntu 20.04. The dropdown for Allow or Blocked Status has the correct width for Location, Camera, Microphone, Notifications and Autoplay permissions. Note that bug 1794752 was found during this verification.

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9297095 [details]
Bug 1793558 - Fix a typo introduced in bug 1784265. r=Itiel

Approved for 106.0.2, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/4bb20234334e

Comment 12

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 106.0.2 (20221024211236) from comment 11 on Windows 10x64, macOS 12, and Ubuntu 20.04. The dropdown for Allow or Blocked Status has the correct width for Location, Camera, Microphone, Notifications, Autoplay, and Virtual Reality permissions.

Comment 13

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified with Firefox 106.0.2 (20221025065831) official build on Windows 10x64, macOS 12 and Ubuntu 20.04. The dropdown for Allow or Blocked Status has the correct width for Location, Camera, Microphone, Notifications, Autoplay, and Virtual Reality permissions.