1794752 - Autoplay settings text for allowed or blocked status overflows due to narrow column width

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image (8).png

Found in

• 107.0a1 (20221011160345)

Affected versions

• 107.0a1 (20221011160345)
• 106.0 (20221010110315) - the text is displayed properly because of bug 1793558 but shortening the Status box will cause the text to be clipped
• 105.0.3 (20221007134813) - the text is displayed properly because of bug 1793558 but shortening the Status box will cause the text to be clipped

Tested platforms

• Affected platforms: macOS 12.3 , Windows 10x64, Ubuntu 20.04
• Unaffected platforms: none

Steps to reproduce

1. Open https://strifer.link/html-video-autoplay-test/.
2. Change the status to Allow or Block Audio and viddeo from the URL bar.
3. Open about:preferences#privacy > Autoplay and observe the status text.

Expected result

• The text has the correct font size and the entire text is displayed after bug 1793558 is fixed.

Actual result

• The text is bigger and after bug 1793558 is fixed the text is clipped.

Regression range

• Last good revision: 5d4ec1262b2e579217133d276309e6ccdce1c28a
  17:58.41 INFO: First bad revision: b2bdddc979f368917b07162504961bc5690fff8a
  17:58.41 INFO: Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5d4ec1262b2e579217133d276309e6ccdce1c28a&tochange=b2bdddc979f368917b07162504961bc5690fff8a
  Potential regressor: bug 1784488.
  I will set bug 1784488 as a regressor because increasing the text size will display a clipped text after fixing bug 1793558.

Additional notes

• Attached a screenshot with the issue.
• Allow Audio and Video and Block Audio and Video options are cut of even if the dropdown is opened.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1784488, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784488

Comment 3

[:Gijs (he/him)]

It's not completely clear to me what the relation with 1784488 is - bug 1802508 seems to have set width CSS style props on the menulist here, where before we were using width attributes, and this is why it's getting cut off. Without that, it'd be much wider. That's just hardcoded to 75px at https://searchfox.org/mozilla-central/rev/5ccb73c0217d1710b10d6e6e297cf3396d10ec23/browser/components/preferences/dialogs/sitePermissions.js#352 . Looks like that originally happened in bug 1558452. Dale, as you wrote the patch there, can you help? Is this just a case of "75px should be enough for anyone" and the autoplay settings has dropdowns with longer strings than the other permission dialogs, and the em changes from bug 1784488 meant the font or padding on these items is now slightly wider?

The simple fix might be just upping the 75px to a slightly higher value so en-US text doesn't get elided. A better fix would probably be rewriting this table to use proper grid or flexbox layout, with a min-width for the dropdown column, and take the scrollbar size into account. That way the column headers can't get out of whack with the main content. This is assuming that the menulists grow appropriately based on their content, and I'm not 100% sure that's true today.

Comment 4

[Dale Harvey (:daleharvey)]

Sure I can take a look

Comment 5

[Dale Harvey (:daleharvey)]

Attachment: Bug 1794752 - Increase status column width. r=Gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45e53ab546f0
Increase status column width. r=Gijs,settings-reviewers,desktop-theme-reviewers

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/45e53ab546f0

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 121.0b3 on Windows 10x64, macOS 12 and Ubuntu 22. The status is correctly displayed after following the steps from comment 0.