1793656 - Create page-agnostic tests for feature callout surface

Status: NEW

(Firefox :: Messaging System, enhancement, P2)

Description

[Jason Prickett]

The scope of this bug is to create page-agnostic tests, and browser chrome specific tests for the feature callout surface

Comment 1

[Shane Hughes [:aminomancer]]

While we're at it, I think we should also change the organization of feature callout tests in general. For example, we should move browser_feature_callout_theme.js out of the fx view tree and into browser/components/newtab. It might be best if we just merge it with browser_feature_callout.js, and move all the Firefox View-specific tasks out of that file (refactoring the tasks that don't really test Fx View itself but just happen to load Fx View-specific messages for expedience) and into a new browser_feature_callout_fx_view.js file that we leave in the fx view tree.

So we'd certainly want to organize the majority of the feature callout tasks into a file (or set of files) dedicated to testing the surface itself, not necessarily testing any specific local implementations of it. And make new test files dedicated to those specific implementations (fx view and pdf.js). Just for the sake of making these tests more comprehensible to fresh eyes.

But even having done that, I'm not sure we'd want to leave those fx view-specific tests in the firefox view tree, apart from the other feature callout tests. Maybe it's better to keep all these files together, because the firefox view tests don't need any support files (aside from the head.js file in the test manifest, for which we only need a couple items that ought to be moved to our own location anyway). All our fx view and pdf.js related feature callout tests can just as easily be run from the newtab browser test manifest. I think that'd make things more straightforward for us, and less confusing for other teams (e.g. frontend folks managing fx view)

Comment 2

[Shane Hughes [:aminomancer]]

This bug relates to the fact that many feature callout tests are actually firefox-view tests, and since they relied on the old Firefox View, they are now skipped. We need to convert them into chrome feature callouts, i.e. run these tests in the main window rather than in an about:firefoxview browser tab.