1793818 - Nightly about screen sizing is still off

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Attachment: Release screenshot

Things are improved with the latest patch, but it's still visually off from Release. Note the wider width and narrower height (leading to text being cut off at the bottom).

If it matters, I'm on a 4K screen with 200% scaling. Happy to test any patches locally if it would help.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Nightly screenshot

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Text doesn't seem cut off, that text is just not present on nightly. I don't have a strong opinion on the size, it's a matter of changing the 500px for some other measure. People seemed to think 620px was too narrow, I dunno :-)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Local build screenshot

This is what I see with my local build with official branding. Shows the cut off text at the bottom better.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Beta107 simulation screenshot

Another data point - I also ran the latest sheriff Beta107 Try simulation build and it shows similar text cutting off with official branding as my local build.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Ah, d'oh, I had missed that, I guess I was testing on a local build.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

No, I don't see the trademark box anywhere, even on the official nightly, wat?

Comment 7

[Emilio Cobos Álvarez (:emilio)]

(And the dom is empty, so it's not a layout issue)

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1793818 - Allow the bottom box of the about dialog to grow. r=bytesized,Gijs

To account for the trademark info. This is a difference between the old
and new flexbox.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/133a845ca01e
Allow the bottom box of the about dialog to grow. r=bytesized

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Can you confirm the fix works? I'm pretty sure it will and tried with an aurora build but some extra checking would be great.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Confirmed that the text isn't being cut off at the bottom. I still think it's too wide, though :)

Comment 12

[Emilio Cobos Álvarez (:emilio)]

I really don't have a strong opinion on the width. Please adjust the 500px here to your liking and suggest a patch maybe in a separate bug? Before the patches here the width was kinda-sorta-intended-to-be 620px including the logo, and the logo is ~250px (for nightly at least), so maybe changing that 500px to be something like 400px or so makes it look better?

Anyways happy to rubber-stamp such a change if it makes it look more similar to the current release rendering and doesn't hurt other locales with more content.

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/133a845ca01e

Comment 14

[Oana Botisan, Desktop QA]

I can still reproduce the issue on latest Nightly 108.0a1. The texy is cut off at the bottom. I can reproduce the issue even on the build from 2022-10-06.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Which OS? Can you file a separate bug for it? I can't repro that but happy to take a look if I can reproduce.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

In nightly there's no text, fwiw. Maybe you got confused by that. I guess this would need to be verified only on actual late-beta builds?

Comment 17

[Oana Botisan, Desktop QA]

Attachment: Screenshot 2022-10-24 at 16.34.28.png

Thank you for the clarification regarding the text.
I tested on macOS 12.5.1. As you can see the About Nightly window is still bigger than the one from Firefox 107.0b4 and Firefix 106.0.1. Is this expected?
I can reproduce this on Windows 10 x64 as well.

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Nightly window being slightly bigger is not super surprising because we have the "NIGHTLY" text there and the "Want to help" text. The text in the beta screenshot shows that the bottom text is visible, which is what this bug fixed. So that seems all expected behavior.

Comment 19

[Oana Botisan, Desktop QA]

Alright. Thank you for all the info.
I will marked this issue as verified fixed.