1796578 - Use a lazy pref getter for checking "dom.sitepermsaddon-provider.enabled" pref from SitePermsAddonProvider.sys.mjs

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As a followup to Bug 1794162, we may use a lazy pref getter for checking "dom.sitepermsaddon-provider.enabled" from the SitePermsAddonProvider's isEnabled getter.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1796578 - Use a lazy pref getter for checking dom.sitepermsaddon-provider.enabled pref from SitePermsAddonProvider.sys.mjs. r?nchevobbe!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cea85f67c505
Use a lazy pref getter for checking dom.sitepermsaddon-provider.enabled pref from SitePermsAddonProvider.sys.mjs. r=nchevobbe

Comment 3

[Cristian Tuns]

Backed out for causing build bustages TestDoublyLinkedList.exe_syms.track

• Backout link
• Push with failures
• Failure Log
• Failure line: gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:655: TestDoublyLinkedList.exe_syms.track] Error 1

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Cristian Tuns from comment #3)

Backed out for causing build bustages TestDoublyLinkedList.exe_syms.track

• Backout link
• Push with failures
• Failure Log
• Failure line: gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:655: TestDoublyLinkedList.exe_syms.track] Error 1

I never say "never", but I can't see (at least not yet) how the patch landed (which has a small change only applied to an sys.mjs Js module: cea85f67c505) could trigger that build error.

Also it seems that in the job with the failure the build job has been retriggered and it didn't fail the second time:

• https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&searchStr=windows%2C2012%2Cdebug%2Cbuild-win32%2Fdebug%2Cb&revision=cea85f67c505160cdc790c0240a41fc569788afd&selectedTaskRun=d2w9KLzcTiiVJuO8eJQs2A.1

Hi Cristian,
could it be a false positive? would you mind to double-check if that is the case?
could you reland the patch if it turns out to be a false positive or should I?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60a2ee63557c
Use a lazy pref getter for checking dom.sitepermsaddon-provider.enabled pref from SitePermsAddonProvider.sys.mjs. r=nchevobbe r=reland CLOSED TREE

Comment 6

[Iulian Moraru]

The patch is relanded, sorry for the inconvenience.

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Iulian Moraru from comment #6)

The patch is relanded, sorry for the inconvenience.

no worries, and thanks a lot for confirming it and relanding the patch!

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/60a2ee63557c