1794351 - Some PDF files with forms appear blank

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Marco Castelluccio [:marco]]

See https://github.com/mozilla/pdf.js/issues/15557.
Filed here on Bugzilla to track the regression.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Pretty straightforward backport if we wanted to fix this in 106 still. I've verified that the PDF linked from the upstream issue renders correctly with the below Try build.
https://treeherder.mozilla.org/jobs?repo=try&revision=67f9832ed1541be98fef6819fa9e11f450ab599d

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1794351 - Ensure that `Page.getOperatorList` handles Annotation parsing errors correctly. r=calixte

Backport of upstream commit:
https://github.com/mozilla/pdf.js/commit/348665934e195a7d7af7f09ecfe26cbc7f2f9751

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9298012 [details]
Bug 1794351 - Ensure that Page.getOperatorList handles Annotation parsing errors correctly. r=calixte

Beta/Release Uplift Approval Request

• User impact if declined: Missing content on some PDF forms
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Verify PDF from upstream issue shows the expected label on the checkbox.
  https://github.com/mozilla/pdf.js/files/9743656/checkbox-incomplete-appearance.pdf
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small, self-contained patch. Good ride-along candidate.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 107.0a1 (2022-10-10) on Win 10 x64.
I can confirm this issue is fixed, I verified using latest nightly Firefox 107.0a1 (2022-10-11) on Windows 10 x64, Ubuntu 22 and macOS 12, the PDF document shows the expected "Check Box" label.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:Snuffleupagus, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Marco Castelluccio [:marco]]

The patch is already nominated for uplift. The bot didn't realize it because it's nominated for release.

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9298012 [details]
Bug 1794351 - Ensure that Page.getOperatorList handles Annotation parsing errors correctly. r=calixte

Approved for 106.0.2, thanks.

Comment 8

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-release/rev/41fa8596ec50

Comment 9

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 106.0.2 on Windows 10 x64, Ubuntu 22 and macOS 12, the PDF document shows the expected "Check Box" label.